Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: telemetry/telemetry/timeline/trace_data.py

Issue 1998673003: [Telemetry] Change how trace_data detects if data being added is valid. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/timeline/trace_data.py
diff --git a/telemetry/telemetry/timeline/trace_data.py b/telemetry/telemetry/timeline/trace_data.py
index bda70fc76a9b512250cb0896b5d14bfab3f969df..e772af46f7d178342cba069fd460225d2aea40b8 100644
--- a/telemetry/telemetry/timeline/trace_data.py
+++ b/telemetry/telemetry/timeline/trace_data.py
@@ -185,7 +185,7 @@ class TraceDataBuilder(object):
self._raw_data = None
return data
- def AddEventsTo(self, part, events, as_string=False):
+ def AddEventsTo(self, part, events):
"""Note: this won't work when called from multiple browsers.
Each browser's trace_event_impl zeros its timestamps when it writes them
@@ -195,12 +195,15 @@ class TraceDataBuilder(object):
if self._raw_data == None:
raise Exception('Already called AsData() on this builder.')
- if as_string:
- assert isinstance(events, basestring)
- self._raw_data[part.raw_field_name] = events
- else:
- assert isinstance(events, list)
+ if isinstance(events, basestring):
+ if part.raw_field_name in self._raw_data:
+ self._raw_data[part.raw_field_name] += events
+ else:
+ self._raw_data[part.raw_field_name] = events
+ elif isinstance(events, list):
self._raw_data.setdefault(part.raw_field_name, []).extend(events)
+ else:
+ raise TypeError('Trace event of unkown type being added. %s' % events)
def HasEventsFor(self, part):
return _HasEventsFor(part, self._raw_data)

Powered by Google App Engine
This is Rietveld 408576698