Desktop MD Site Settings: Re-order the permission list.

chrome/browser/resources/settings/site_settings/site_details.html

Index: chrome/browser/resources/settings/site_settings/site_details.html
diff --git a/chrome/browser/resources/settings/site_settings/site_details.html b/chrome/browser/resources/settings/site_settings/site_details.html
index b1008c8e1017efaef6b233bb0392d0b22e96da95..265fdf20e7f875f7bfb1f9629fdde19714132a48 100644
--- a/chrome/browser/resources/settings/site_settings/site_details.html
+++ b/chrome/browser/resources/settings/site_settings/site_details.html
@@ -26,30 +26,33 @@
             alt="$i18n{siteSettingsDelete}"></paper-icon-button>
       </paper-item>
       <h2>$i18n{siteSettingsPermissions}</h2>
+
+      <!-- The order of the following items from: http://crbug.com/610358. -->

[michaelpg, 2016/05/23 18:14:22]

nit: we can't comment every feature that's specified in a bug. we just generally
assume our code is written as intended. if the desired ordering changes or a
permission type is added or removed, the comment will be out of date. we should
trust that nobody will re-order these without good reason.

[Finnur, 2016/05/25 18:41:29]

My thinking behind this was that random people are going to be adding new types
in the future and I might not catch all of them. History tells me they would be
tempted to add theirs in somewhere random, not knowing that there's both a
pre-determined order and multiple places to update.

But, I don't feel strongly about this, so I've removed the comment from both
locations.

       <site-details-permission site="[[site]]" id="cookies"
           category="{{ContentSettingsTypes.COOKIES}}">
       </site-details-permission>
-      <site-details-permission site="[[site]]" id="javascript"
-          category="{{ContentSettingsTypes.JAVASCRIPT}}">
-      </site-details-permission>
-      <site-details-permission site="[[site]]" id="popups"
-          category="{{ContentSettingsTypes.POPUPS}}">
-      </site-details-permission>
       <site-details-permission site="[[site]]" id="geolocation"
           category="{{ContentSettingsTypes.GEOLOCATION}}">
       </site-details-permission>
-      <site-details-permission site="[[site]]" id="notification"
-          category="{{ContentSettingsTypes.NOTIFICATIONS}}">
-      </site-details-permission>
-      <site-details-permission site="[[site]]" id="fullscreen"
-          category="{{ContentSettingsTypes.FULLSCREEN}}">
-      </site-details-permission>
       <site-details-permission site="[[site]]" id="camera"
           category="{{ContentSettingsTypes.CAMERA}}">
       </site-details-permission>
       <site-details-permission site="[[site]]" id="mic"
           category="{{ContentSettingsTypes.MIC}}">
       </site-details-permission>
+      <site-details-permission site="[[site]]" id="notification"
+          category="{{ContentSettingsTypes.NOTIFICATIONS}}">
+      </site-details-permission>
+      <site-details-permission site="[[site]]" id="javascript"
+          category="{{ContentSettingsTypes.JAVASCRIPT}}">
+      </site-details-permission>
+      <site-details-permission site="[[site]]" id="popups"
+          category="{{ContentSettingsTypes.POPUPS}}">
+      </site-details-permission>
+      <site-details-permission site="[[site]]" id="fullscreen"
+          category="{{ContentSettingsTypes.FULLSCREEN}}">
+      </site-details-permission>
+
       <paper-button on-tap="onClearAndReset_" raised class="reset-button">
         $i18n{siteSettingsClearAndReset}
       </paper-button>