Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_details.html

Issue 1998673002: Desktop MD Site Settings: Re-order the permission list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
5 <link rel="import" href="chrome://md-settings/icons.html"> 5 <link rel="import" href="chrome://md-settings/icons.html">
6 <link rel="import" href="chrome://md-settings/settings_shared_css.html"> 6 <link rel="import" href="chrome://md-settings/settings_shared_css.html">
7 <link rel="import" href="chrome://md-settings/site_settings/constants.html"> 7 <link rel="import" href="chrome://md-settings/site_settings/constants.html">
8 <link rel="import" href="chrome://md-settings/site_settings/site_details_permiss ion.html"> 8 <link rel="import" href="chrome://md-settings/site_settings/site_details_permiss ion.html">
9 <link rel="import" href="chrome://md-settings/site_settings/site_settings_behavi or.html"> 9 <link rel="import" href="chrome://md-settings/site_settings/site_settings_behavi or.html">
10 <link rel="import" href="chrome://md-settings/site_settings/website_usage_privat e_api.html"> 10 <link rel="import" href="chrome://md-settings/site_settings/website_usage_privat e_api.html">
11 11
12 <dom-module id="site-details"> 12 <dom-module id="site-details">
13 <link rel="import" type="css" href="site_details.css"> 13 <link rel="import" type="css" href="site_details.css">
14 <template> 14 <template>
15 <style include="settings-shared"></style> 15 <style include="settings-shared"></style>
16 <div class="settings-box block"> 16 <div class="settings-box block">
17 <div class="horizontal layout origin-box"> 17 <div class="horizontal layout origin-box">
18 <div class="website-icon" style$="[[computeSiteIcon(site)]]"></div> 18 <div class="website-icon" style$="[[computeSiteIcon(site)]]"></div>
19 <div class="origin flex">[[site.originForDisplay]]</div> 19 <div class="origin flex">[[site.originForDisplay]]</div>
20 </div> 20 </div>
21 <h2 id="usage" hidden$="[[!storedData_]]">$i18n{siteSettingsUsage}</h2> 21 <h2 id="usage" hidden$="[[!storedData_]]">$i18n{siteSettingsUsage}</h2>
22 <paper-item id="storage" hidden$="[[!storedData_]]"> 22 <paper-item id="storage" hidden$="[[!storedData_]]">
23 <div class="flex">[[storedData_]]</div> 23 <div class="flex">[[storedData_]]</div>
24 <paper-icon-button icon="settings:delete" 24 <paper-icon-button icon="settings:delete"
25 on-tap="onClearStorage_" 25 on-tap="onClearStorage_"
26 alt="$i18n{siteSettingsDelete}"></paper-icon-button> 26 alt="$i18n{siteSettingsDelete}"></paper-icon-button>
27 </paper-item> 27 </paper-item>
28 <h2>$i18n{siteSettingsPermissions}</h2> 28 <h2>$i18n{siteSettingsPermissions}</h2>
29
30 <!-- The order of the following items from: http://crbug.com/610358. -->
michaelpg 2016/05/23 18:14:22 nit: we can't comment every feature that's specifi
Finnur 2016/05/25 18:41:29 My thinking behind this was that random people are
29 <site-details-permission site="[[site]]" id="cookies" 31 <site-details-permission site="[[site]]" id="cookies"
30 category="{{ContentSettingsTypes.COOKIES}}"> 32 category="{{ContentSettingsTypes.COOKIES}}">
31 </site-details-permission> 33 </site-details-permission>
34 <site-details-permission site="[[site]]" id="geolocation"
35 category="{{ContentSettingsTypes.GEOLOCATION}}">
36 </site-details-permission>
37 <site-details-permission site="[[site]]" id="camera"
38 category="{{ContentSettingsTypes.CAMERA}}">
39 </site-details-permission>
40 <site-details-permission site="[[site]]" id="mic"
41 category="{{ContentSettingsTypes.MIC}}">
42 </site-details-permission>
43 <site-details-permission site="[[site]]" id="notification"
44 category="{{ContentSettingsTypes.NOTIFICATIONS}}">
45 </site-details-permission>
32 <site-details-permission site="[[site]]" id="javascript" 46 <site-details-permission site="[[site]]" id="javascript"
33 category="{{ContentSettingsTypes.JAVASCRIPT}}"> 47 category="{{ContentSettingsTypes.JAVASCRIPT}}">
34 </site-details-permission> 48 </site-details-permission>
35 <site-details-permission site="[[site]]" id="popups" 49 <site-details-permission site="[[site]]" id="popups"
36 category="{{ContentSettingsTypes.POPUPS}}"> 50 category="{{ContentSettingsTypes.POPUPS}}">
37 </site-details-permission> 51 </site-details-permission>
38 <site-details-permission site="[[site]]" id="geolocation"
39 category="{{ContentSettingsTypes.GEOLOCATION}}">
40 </site-details-permission>
41 <site-details-permission site="[[site]]" id="notification"
42 category="{{ContentSettingsTypes.NOTIFICATIONS}}">
43 </site-details-permission>
44 <site-details-permission site="[[site]]" id="fullscreen" 52 <site-details-permission site="[[site]]" id="fullscreen"
45 category="{{ContentSettingsTypes.FULLSCREEN}}"> 53 category="{{ContentSettingsTypes.FULLSCREEN}}">
46 </site-details-permission> 54 </site-details-permission>
47 <site-details-permission site="[[site]]" id="camera" 55
48 category="{{ContentSettingsTypes.CAMERA}}">
49 </site-details-permission>
50 <site-details-permission site="[[site]]" id="mic"
51 category="{{ContentSettingsTypes.MIC}}">
52 </site-details-permission>
53 <paper-button on-tap="onClearAndReset_" raised class="reset-button"> 56 <paper-button on-tap="onClearAndReset_" raised class="reset-button">
54 $i18n{siteSettingsClearAndReset} 57 $i18n{siteSettingsClearAndReset}
55 </paper-button> 58 </paper-button>
56 </div> 59 </div>
57 <website-usage-private-api id="usageApi" 60 <website-usage-private-api id="usageApi"
58 website-data-usage="{{storedData_}}" 61 website-data-usage="{{storedData_}}"
59 website-storage-type="{{storageType_}}"> 62 website-storage-type="{{storageType_}}">
60 </website-usage-private-api> 63 </website-usage-private-api>
61 </template> 64 </template>
62 <script src="site_details.js"></script> 65 <script src="site_details.js"></script>
63 </dom-module> 66 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698