Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1998673002: Desktop MD Site Settings: Re-order the permission list. (Closed)

Created:
4 years, 7 months ago by Finnur
Modified:
4 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Desktop MD Site Settings: Re-order the permission list. Covers both the top-level categories and permission list within the Site Details. No functionality should change as a result. BUG=610358 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/16b11315b0cd6a85204055f65f38560ea9c16ca1 Cr-Commit-Position: refs/heads/master@{#395965}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M chrome/browser/resources/settings/site_settings/site_details.html View 1 2 1 chunk +14 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/site_settings_page/site_settings_page.html View 1 2 2 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Finnur
4 years, 7 months ago (2016-05-23 10:52:48 UTC) #5
Finnur
4 years, 7 months ago (2016-05-23 10:52:49 UTC) #6
michaelpg
lgtm https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resources/settings/site_settings/site_details.html File chrome/browser/resources/settings/site_settings/site_details.html (right): https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resources/settings/site_settings/site_details.html#newcode30 chrome/browser/resources/settings/site_settings/site_details.html:30: <!-- The order of the following items from: ...
4 years, 7 months ago (2016-05-23 18:14:23 UTC) #7
Finnur
https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resources/settings/site_settings/site_details.html File chrome/browser/resources/settings/site_settings/site_details.html (right): https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resources/settings/site_settings/site_details.html#newcode30 chrome/browser/resources/settings/site_settings/site_details.html:30: <!-- The order of the following items from: http://crbug.com/610358. ...
4 years, 7 months ago (2016-05-25 18:41:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998673002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998673002/60001
4 years, 7 months ago (2016-05-25 18:42:22 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-25 19:47:38 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 19:49:42 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/16b11315b0cd6a85204055f65f38560ea9c16ca1
Cr-Commit-Position: refs/heads/master@{#395965}

Powered by Google App Engine
This is Rietveld 408576698