Desktop MD Site Settings: Re-order the permission list.

Desktop MD Site Settings: Re-order the permission list.

Covers both the top-level categories and permission
list within the Site Details.

No functionality should change as a result.

BUG=610358
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/16b11315b0cd6a85204055f65f38560ea9c16ca1
Cr-Commit-Position: refs/heads/master@{#395965}

[Finnur, 2016-05-19 15:38:42]

Description was changed from

==========
Desktop MD Site Settings: Re-order the permission list.

Covers both the top-level categories and permission
list within the Site Details.

BUG=610358
==========

to

==========
Desktop MD Site Settings: Re-order the permission list.

Covers both the top-level categories and permission
list within the Site Details.

BUG=610358
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-05-23 10:47:07]

Patchset #2 (id:20001) has been deleted

[Finnur, 2016-05-23 10:52:39]

Description was changed from

==========
Desktop MD Site Settings: Re-order the permission list.

Covers both the top-level categories and permission
list within the Site Details.

BUG=610358
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Desktop MD Site Settings: Re-order the permission list.

Covers both the top-level categories and permission
list within the Site Details.

No functionality should change as a result.

BUG=610358
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-05-23 10:52:39]

finnur@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2016-05-23 18:14:23]

lgtm

https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details.html (right):

https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.html:30: <!-- The
order of the following items from: http://crbug.com/610358. -->
nit: we can't comment every feature that's specified in a bug. we just generally
assume our code is written as intended. if the desired ordering changes or a
permission type is added or removed, the comment will be out of date. we should
trust that nobody will re-order these without good reason.

https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/site_settings_page/site_settings_page.html
(right):

https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings_page/site_settings_page.html:13:
<!-- The order of the following items from: http://crbug.com/610358. -->
same

[Finnur, 2016-05-25 18:41:29]

https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details.html (right):

https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.html:30: <!-- The
order of the following items from: http://crbug.com/610358. -->
My thinking behind this was that random people are going to be adding new types
in the future and I might not catch all of them. History tells me they would be
tempted to add theirs in somewhere random, not knowing that there's both a
pre-determined order and multiple places to update.

But, I don't feel strongly about this, so I've removed the comment from both
locations.

https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/settings/site_settings_page/site_settings_page.html
(right):

https://codereview.chromium.org/1998673002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings_page/site_settings_page.html:13:
<!-- The order of the following items from: http://crbug.com/610358. -->
On 2016/05/23 18:14:22, michaelpg wrote:
> same

Done.

[Finnur, 2016-05-25 18:41:55]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-05-25 18:41:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1998673002/#ps60001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-05-25 18:42:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998673002/60001

[commit-bot: I haz the power, 2016-05-25 19:47:37]

Description was changed from

==========
Desktop MD Site Settings: Re-order the permission list.

Covers both the top-level categories and permission
list within the Site Details.

No functionality should change as a result.

BUG=610358
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Desktop MD Site Settings: Re-order the permission list.

Covers both the top-level categories and permission
list within the Site Details.

No functionality should change as a result.

BUG=610358
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-25 19:47:38]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-25 19:49:41]

Description was changed from

==========
Desktop MD Site Settings: Re-order the permission list.

Covers both the top-level categories and permission
list within the Site Details.

No functionality should change as a result.

BUG=610358
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Desktop MD Site Settings: Re-order the permission list.

Covers both the top-level categories and permission
list within the Site Details.

No functionality should change as a result.

BUG=610358
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/16b11315b0cd6a85204055f65f38560ea9c16ca1
Cr-Commit-Position: refs/heads/master@{#395965}
==========

[commit-bot: I haz the power, 2016-05-25 19:49:42]

Patchset 3 (id:??) landed as
https://crrev.com/16b11315b0cd6a85204055f65f38560ea9c16ca1
Cr-Commit-Position: refs/heads/master@{#395965}