Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1998593002: [Interpreter] Inline ToBooleanStub and do some cleanup on unary ops. (Closed)

Created:
4 years, 7 months ago by rmcilroy
Modified:
4 years, 7 months ago
Reviewers:
epertoso, mythria
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Inline ToBooleanStub and do some cleanup on unary ops. Inlines the ToBoolean operations in the interpreter. Also do some cleanup to unify UnaryOp helper in the Interpreter, remove the unused BinaryOp Runtime call helper and remove extra newlines. BUG=v8:4280 LOG=N Committed: https://crrev.com/9c6a52be6044326343cc7c22c4438a3b97ac25e1 Cr-Commit-Position: refs/heads/master@{#36366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -149 lines) Patch
M src/code-stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.cc View 3 chunks +21 lines, -6 lines 0 comments Download
M src/interpreter/interpreter.h View 3 chunks +13 lines, -10 lines 0 comments Download
M src/interpreter/interpreter.cc View 57 chunks +57 lines, -132 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998593002/1
4 years, 7 months ago (2016-05-19 11:43:53 UTC) #2
rmcilroy
Enrico: please review code stub changes Mythri: please review interpreter changed. Thanks.
4 years, 7 months ago (2016-05-19 11:44:41 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 12:16:11 UTC) #6
epertoso
lgtm
4 years, 7 months ago (2016-05-19 12:25:48 UTC) #7
mythria
lgtm
4 years, 7 months ago (2016-05-19 13:07:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998593002/1
4 years, 7 months ago (2016-05-19 13:39:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 13:41:03 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 13:43:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c6a52be6044326343cc7c22c4438a3b97ac25e1
Cr-Commit-Position: refs/heads/master@{#36366}

Powered by Google App Engine
This is Rietveld 408576698