Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: src/interpreter/interpreter.h

Issue 1998593002: [Interpreter] Inline ToBooleanStub and do some cleanup on unary ops. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter.h
diff --git a/src/interpreter/interpreter.h b/src/interpreter/interpreter.h
index d774d8bb7de14afc4e9f218ddd576944afbf2cff..0cfae7904ea693f4925d575df1a8ee349b7040bc 100644
--- a/src/interpreter/interpreter.h
+++ b/src/interpreter/interpreter.h
@@ -73,14 +73,13 @@ class Interpreter {
// Generates code to perform the binary operation via |callable|.
void DoBinaryOp(Callable callable, InterpreterAssembler* assembler);
- // Generates code to perform the binary operation via |function_id|.
- void DoBinaryOp(Runtime::FunctionId function_id,
- InterpreterAssembler* assembler);
-
// Generates code to perform the binary operation via |Generator|.
template <class Generator>
void DoBinaryOp(InterpreterAssembler* assembler);
+ // Generates code to perform the unary operation via |callable|.
+ void DoUnaryOp(Callable callable, InterpreterAssembler* assembler);
+
// Generates code to perform the unary operation via |Generator|.
template <class Generator>
void DoUnaryOp(InterpreterAssembler* assembler);
@@ -125,12 +124,6 @@ class Interpreter {
// Generates code to perform a constructor call.
void DoCallConstruct(InterpreterAssembler* assembler);
- // Generates code to perform a type conversion.
- void DoTypeConversionOp(Callable callable, InterpreterAssembler* assembler);
-
- // Generates code to perform logical-not on boolean |value|.
- void DoLogicalNotOp(compiler::Node* value, InterpreterAssembler* assembler);
-
// Generates code to perform delete via function_id.
void DoDelete(Runtime::FunctionId function_id,
InterpreterAssembler* assembler);
@@ -143,6 +136,16 @@ class Interpreter {
void DoStoreLookupSlot(LanguageMode language_mode,
InterpreterAssembler* assembler);
+ // Generates code to perform logical-not on boolean |value| and returns the
+ // result.
+ compiler::Node* BuildLogicalNot(compiler::Node* value,
+ InterpreterAssembler* assembler);
+
+ // Generates code to convert |value| to a boolean and returns the
+ // result.
+ compiler::Node* BuildToBoolean(compiler::Node* value,
+ InterpreterAssembler* assembler);
+
uintptr_t GetDispatchCounter(Bytecode from, Bytecode to) const;
// Get dispatch table index of bytecode.
« no previous file with comments | « src/code-stubs.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698