Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1998543004: Fixes crash in ~ShellConnection (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes crash in ~ShellConnection Code was assuming a WindowManagerConnection has been created, which is not necessarily the case. In particular if you run a single test and the test doesn't talk to mus you hit the check. BUG=613018 TEST=test only change R=sadrul@chromium.org Committed: https://crrev.com/56172f6d40ecf4dc259a05d37df4bd2ac8789846 Cr-Commit-Position: refs/heads/master@{#394795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/views/mus/display_list_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 7 months ago (2016-05-19 15:58:28 UTC) #1
sadrul
lgtm
4 years, 7 months ago (2016-05-19 16:21:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998543004/1
4 years, 7 months ago (2016-05-19 16:29:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 16:43:08 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 16:45:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56172f6d40ecf4dc259a05d37df4bd2ac8789846
Cr-Commit-Position: refs/heads/master@{#394795}

Powered by Google App Engine
This is Rietveld 408576698