ui/views/mus/views_mus_test_suite.cc - Issue 1998543004: Fixes crash in ~ShellConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/mus/views_mus_test_suite.cc

Issue 1998543004: Fixes crash in ~ShellConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/mus/views_mus_test_suite.cc

diff --git a/ui/views/mus/views_mus_test_suite.cc b/ui/views/mus/views_mus_test_suite.cc

index 2919115d6796744b581734dabc374f0ca27577ea..a101f3b19bef576c91b5c37fad082457769c67e7 100644

--- a/ui/views/mus/views_mus_test_suite.cc

+++ b/ui/views/mus/views_mus_test_suite.cc

@@ -85,7 +85,8 @@ class ShellConnection {

}

~ShellConnection() {

- views::WindowManagerConnection::Reset();

+ if (views::WindowManagerConnection::Exists())

+ views::WindowManagerConnection::Reset();

base::WaitableEvent wait(false, false);

thread_.task_runner()->PostTask(

FROM_HERE, base::Bind(&ShellConnection::TearDownConnections,

« no previous file with comments | « ui/views/mus/display_list_unittest.cc ('k') | no next file » | no next file with comments »