Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1998543002: telemetry: Update tough_path_rendering_cases Chalkboard test URL (Closed)

Created:
4 years, 7 months ago by Kimmo Kinnunen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

telemetry: Update tough_path_rendering_cases Chalkboard test URL Update tough_path_rendering_cases Chalkboard test URL. The old url would go to a page that would load the content in an iframe. The injected script would fail. Load the iframe URL instead. Loading the main document would inject the script to the parent main document. The injected code would start the test by click()ing an element cross domains, which would be rejected. Fixing is needed in order to record new content to tough_path_rendering_cases. BUG=594928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M tools/perf/page_sets/data/tough_path_rendering_cases.json View 1 chunk +5 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/tough_path_rendering_cases_001.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/tough_path_rendering_cases.py View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (3 generated)
Kimmo Kinnunen
PTAL, note that I can not upload to Cloud Storage. Used --bypass-hooks to upload this.
4 years, 7 months ago (2016-05-19 07:59:46 UTC) #2
nednguyen
On 2016/05/19 07:59:46, Kimmo Kinnunen wrote: > PTAL, note that I can not upload to ...
4 years, 7 months ago (2016-05-19 15:29:47 UTC) #3
Stephen White
On 2016/05/19 07:59:46, Kimmo Kinnunen wrote: > PTAL, note that I can not upload to ...
4 years, 7 months ago (2016-05-19 15:33:30 UTC) #4
nednguyen
On 2016/05/19 15:33:30, Stephen White wrote: > On 2016/05/19 07:59:46, Kimmo Kinnunen wrote: > > ...
4 years, 7 months ago (2016-05-19 15:37:17 UTC) #5
nednguyen
On 2016/05/19 15:37:17, nednguyen wrote: > On 2016/05/19 15:33:30, Stephen White wrote: > > On ...
4 years, 7 months ago (2016-05-19 22:24:27 UTC) #6
Stephen White
On 2016/05/19 22:24:27, nednguyen wrote: > On 2016/05/19 15:37:17, nednguyen wrote: > > On 2016/05/19 ...
4 years, 7 months ago (2016-05-19 22:26:01 UTC) #9
Stephen White
On 2016/05/19 22:26:01, Stephen White wrote: > On 2016/05/19 22:24:27, nednguyen wrote: > > On ...
4 years, 7 months ago (2016-05-24 15:24:09 UTC) #10
Kimmo Kinnunen
On 2016/05/24 15:24:09, Stephen White wrote: > Just to let you know I haven't forgotten ...
4 years, 6 months ago (2016-06-08 11:30:34 UTC) #11
Stephen White
4 years, 6 months ago (2016-06-09 18:27:49 UTC) #12
On 2016/06/08 11:30:34, Kimmo Kinnunen wrote:
> friendly ping

Sorry for the delay. I've uploaded the WPR, and upload the resulting CL to 
https://codereview.chromium.org/2055823004/ since the hash was different.

Powered by Google App Engine
This is Rietveld 408576698