Issue 1998473002: Support @JS with path expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1998473002: Support @JS with path expressions. (Closed)

Created:
4 years, 7 months ago by Siggi Cherem (dart-lang)

Modified:
4 years, 7 months ago

Reviewers:
vsm, Harry Terkelsen, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org, vsm

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	lib/src/compiler/code_generator.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 6 (3 generated)

Siggi Cherem (dart-lang)

This let's us handle code like: @JS('window.location.href') external String get _url; (we were otherwise generating ...

4 years, 7 months ago (2016-05-19 01:08:19 UTC) #2

Siggi Cherem (dart-lang)

4 years, 7 months ago (2016-05-19 16:23:38 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a6ea7c9fa7cecb9b31226f317288e765034bb357 (presubmit successful).