runtime/vm/stub_code_arm.cc - Issue 1998263002: Include multiplication in the megamorphic cache hash to avoid cid ranges overlapping modulo table s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 1998263002: Include multiplication in the megamorphic cache hash to avoid cid ranges overlapping modulo table s… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_arm.cc

diff --git a/runtime/vm/stub_code_arm.cc b/runtime/vm/stub_code_arm.cc

index e4e32ce34fb0a25a5c37f4b25eb7c8a597b71808..538cd334a66fee268c7fa262e39523e2fae52e41 100644

--- a/runtime/vm/stub_code_arm.cc

+++ b/runtime/vm/stub_code_arm.cc

@@ -2055,7 +2055,8 @@ void StubCode::EmitMegamorphicLookup(Assembler* assembler) {

__ ldr(R1, FieldAddress(R9, MegamorphicCache::mask_offset()));

// R2: cache buckets array.

// R1: mask.

- __ mov(R3, Operand(R0));

+ __ LoadImmediate(IP, MegamorphicCache::kSpreadFactor);

+ __ mul(R3, R0, IP);

// R3: probe.

Label loop, update, load_target_function;

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »