Workaround for glibc semaphore bug.

Workaround for glibc semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

This patch also removes all instrumentation code that was added to
help with investigation.

BUG=chromium:609249
LOG=NO

Committed: https://crrev.com/84ee947013003d481b1222d975e4456122b6efe9
Cr-Commit-Position: refs/heads/master@{#36407}

[ulan, 2016-05-20 11:22:27]

Description was changed from

==========
Work around for glibc Semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

BUG=chromium:609249
LOG=NO
==========

to

==========
Work around for glibc Semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

This patch also removes all instrumentation code that was added to
help with investigation.

BUG=chromium:609249
LOG=NO
==========

[ulan, 2016-05-20 11:24:14]

Description was changed from

==========
Work around for glibc Semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

This patch also removes all instrumentation code that was added to
help with investigation.

BUG=chromium:609249
LOG=NO
==========

to

==========
Workaround for glibc Semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

This patch also removes all instrumentation code that was added to
help with investigation.

BUG=chromium:609249
LOG=NO
==========

[ulan, 2016-05-20 11:28:09]

Description was changed from

==========
Workaround for glibc Semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

This patch also removes all instrumentation code that was added to
help with investigation.

BUG=chromium:609249
LOG=NO
==========

to

==========
Workaround for glibc semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

This patch also removes all instrumentation code that was added to
help with investigation.

BUG=chromium:609249
LOG=NO
==========

[ulan, 2016-05-20 11:28:24]

ulan@chromium.org changed reviewers:
+ mlippautz@chromium.org

[ulan, 2016-05-20 11:28:25]

ptal

https://codereview.chromium.org/1998213002/diff/1/src/heap/mark-compact.h
File src/heap/mark-compact.h (left):

https://codereview.chromium.org/1998213002/diff/1/src/heap/mark-compact.h#old...
src/heap/mark-compact.h:647: #ifdef DEBUG
I moved this down.

https://codereview.chromium.org/1998213002/diff/1/src/heap/page-parallel-job.h
File src/heap/page-parallel-job.h (left):

https://codereview.chromium.org/1998213002/diff/1/src/heap/page-parallel-job....
src/heap/page-parallel-job.h:100: int aborted_tasks = 0;
All removed lines below are instrumentation code.

[Michael Lippautz, 2016-05-20 11:41:14]

LGTM! Awesome work in tracking down this bug!

[ulan, 2016-05-20 11:43:01]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-05-20 11:43:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998213002/1

[commit-bot: I haz the power, 2016-05-20 12:15:41]

Description was changed from

==========
Workaround for glibc semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

This patch also removes all instrumentation code that was added to
help with investigation.

BUG=chromium:609249
LOG=NO
==========

to

==========
Workaround for glibc semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

This patch also removes all instrumentation code that was added to
help with investigation.

BUG=chromium:609249
LOG=NO
==========

[commit-bot: I haz the power, 2016-05-20 12:15:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-20 12:16:33]

Description was changed from

==========
Workaround for glibc semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

This patch also removes all instrumentation code that was added to
help with investigation.

BUG=chromium:609249
LOG=NO
==========

to

==========
Workaround for glibc semaphore bug.

Instead of dynamically creating semaphore for each page parallel job,
we create one semaphore for MarkCompact and reuse it.

This patch also removes all instrumentation code that was added to
help with investigation.

BUG=chromium:609249
LOG=NO

Committed: https://crrev.com/84ee947013003d481b1222d975e4456122b6efe9
Cr-Commit-Position: refs/heads/master@{#36407}
==========

[commit-bot: I haz the power, 2016-05-20 12:16:34]

Patchset 1 (id:??) landed as
https://crrev.com/84ee947013003d481b1222d975e4456122b6efe9
Cr-Commit-Position: refs/heads/master@{#36407}