Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: src/base/platform/semaphore.cc

Issue 1998213002: Workaround for glibc semaphore bug. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/base/platform/semaphore.cc
diff --git a/src/base/platform/semaphore.cc b/src/base/platform/semaphore.cc
index 64489f91c21d652e53cd04504e001cb4770d0943..a7e522ae75f23d1541db3b78a022addac8ae3ec3 100644
--- a/src/base/platform/semaphore.cc
+++ b/src/base/platform/semaphore.cc
@@ -34,11 +34,10 @@ Semaphore::~Semaphore() {
USE(result);
}
-void Semaphore::Signal(const char* caller) {
+void Semaphore::Signal() {
kern_return_t result = semaphore_signal(native_handle_);
DCHECK_EQ(KERN_SUCCESS, result);
USE(result);
- USE(caller);
}
@@ -104,12 +103,9 @@ Semaphore::~Semaphore() {
USE(result);
}
-void Semaphore::Signal(const char* caller) {
+void Semaphore::Signal() {
int result = sem_post(&native_handle_);
- if (result != 0) {
- V8_Fatal(__FILE__, __LINE__,
- "Semaphore signal failure: %d called by '%s'\n", errno, caller);
- }
+ CHECK_EQ(0, result);
}
@@ -177,12 +173,11 @@ Semaphore::~Semaphore() {
USE(result);
}
-void Semaphore::Signal(const char* caller) {
+void Semaphore::Signal() {
LONG dummy;
BOOL result = ReleaseSemaphore(native_handle_, 1, &dummy);
DCHECK(result);
USE(result);
- USE(caller);
}
« no previous file with comments | « src/base/platform/semaphore.h ('k') | src/debug/debug.cc » ('j') | src/heap/mark-compact.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698