sync: Remove SyncSourceInfo

sync/sessions/sync_session.h

Index: sync/sessions/sync_session.h
diff --git a/sync/sessions/sync_session.h b/sync/sessions/sync_session.h
index 8f4e9edcd3d96f529763675b21be9a9fb012d6d6..28df1282b00b4212c4340eb4f5b4163a06a53d29 100644
--- a/sync/sessions/sync_session.h
+++ b/sync/sessions/sync_session.h
@@ -104,14 +104,18 @@ class SYNC_EXPORT_PRIVATE SyncSession {
   // Build a session without a nudge tracker.  Used for poll or configure type
   // sync cycles.
   static SyncSession* Build(SyncSessionContext* context,
-                            Delegate* delegate,
-                            const SyncSourceInfo& source);
+                            Delegate* delegate);
   ~SyncSession();
 
   // Builds a thread-safe and read-only copy of the current session state.
   SyncSessionSnapshot TakeSnapshot() const;
+  SyncSessionSnapshot TakeSnapshot(

[tim (not reviewing), 2013/08/01 17:16:38]

Style guide forbids overloading functions.  You'll need to rename this something
like TakeLegacySnapshot or something.

[rlarocque, 2013/08/01 21:01:41]

I renamed the second to TakeSnapshotWithSource.

+      sync_pb::GetUpdatesCallerInfo::GetUpdatesSource legacy_updates_source)
+      const;
 
   // Builds and sends a snapshot to the session context's listeners.
+  void SendSyncCycleEndEventNotification(
+    sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source);

[tim (not reviewing), 2013/08/01 17:16:38]

nit- indent.

[rlarocque, 2013/08/01 21:01:41]

Done.

   void SendEventNotification(SyncEngineEvent::EventCause cause);
 
   // TODO(akalin): Split this into context() and mutable_context().
@@ -124,19 +128,13 @@ class SYNC_EXPORT_PRIVATE SyncSession {
     return status_controller_.get();
   }
 
-  const SyncSourceInfo& source() const { return source_; }
-
  private:
   SyncSession(SyncSessionContext* context,
-              Delegate* delegate,
-              const SyncSourceInfo& source);
+              Delegate* delegate);

[tim (not reviewing), 2013/08/01 17:16:38]

does this fit on line above?

[rlarocque, 2013/08/01 21:01:41]

Done.

 
   // The context for this session, guaranteed to outlive |this|.
   SyncSessionContext* const context_;
 
-  // The source for initiating this sync session.
-  SyncSourceInfo source_;
-
   // The delegate for this session, must never be NULL.
   Delegate* const delegate_;