sync: Remove SyncSourceInfo

sync/sessions/sync_session.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A class representing an attempt to synchronize the local syncable data
 // store with a sync server. A SyncSession instance is passed as a stateful
 // bundle to and from various SyncerCommands with the goal of converging the
 // client view of data with that of the server. The commands twiddle with
 // session status in response to events and hiccups along the way, set and
 // query session progress with regards to conflict resolution and applying
@@ skipping 86 matching lines @@
     // will buffer locally.
     virtual void OnReceivedClientInvalidationHintBufferSize(int size) = 0;
 
    protected:
     virtual ~Delegate() {}
   };
 
   // Build a session without a nudge tracker.  Used for poll or configure type
   // sync cycles.
   static SyncSession* Build(SyncSessionContext* context,
-                            Delegate* delegate,
-                            const SyncSourceInfo& source);
+                            Delegate* delegate);
   ~SyncSession();
 
   // Builds a thread-safe and read-only copy of the current session state.
   SyncSessionSnapshot TakeSnapshot() const;
+  SyncSessionSnapshot TakeSnapshot(

[tim (not reviewing), 2013/08/01 17:16:38]

Style guide forbids overloading functions.  You'll need to rename this something
like TakeLegacySnapshot or something.

[rlarocque, 2013/08/01 21:01:41]

I renamed the second to TakeSnapshotWithSource.

+      sync_pb::GetUpdatesCallerInfo::GetUpdatesSource legacy_updates_source)
+      const;
 
   // Builds and sends a snapshot to the session context's listeners.
+  void SendSyncCycleEndEventNotification(
+    sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source);

[tim (not reviewing), 2013/08/01 17:16:38]

nit- indent.

[rlarocque, 2013/08/01 21:01:41]

Done.

   void SendEventNotification(SyncEngineEvent::EventCause cause);
 
   // TODO(akalin): Split this into context() and mutable_context().
   SyncSessionContext* context() const { return context_; }
   Delegate* delegate() const { return delegate_; }
   const StatusController& status_controller() const {
     return *status_controller_.get();
   }
   StatusController* mutable_status_controller() {
     return status_controller_.get();
   }
 
-  const SyncSourceInfo& source() const { return source_; }
-
  private:
   SyncSession(SyncSessionContext* context,
-              Delegate* delegate,
-              const SyncSourceInfo& source);
+              Delegate* delegate);

[tim (not reviewing), 2013/08/01 17:16:38]

does this fit on line above?

[rlarocque, 2013/08/01 21:01:41]

Done.

 
   // The context for this session, guaranteed to outlive |this|.
   SyncSessionContext* const context_;
 
-  // The source for initiating this sync session.
-  SyncSourceInfo source_;
-
   // The delegate for this session, must never be NULL.
   Delegate* const delegate_;
 
   // Our controller for various status and error counters.
   scoped_ptr<StatusController> status_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncSession);
 };
 
 }  // namespace sessions
 }  // namespace syncer
 
 #endif  // SYNC_SESSIONS_SYNC_SESSION_H_