Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1998033004:
Whitelist Hangouts, including Chromebox for Meetings, for ChromeVox Next (Closed)
|
Created:
4 years, 7 months ago by dmazzoni Modified:
4 years, 7 months ago Reviewers:
David Tseng CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWhitelist Hangouts, including Chromebox for Meetings, for ChromeVox Next
BUG=613694
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/69cc7b82b9db14e2eb2d3a78299ffa3a8dbcdbb7
Cr-Commit-Position: refs/heads/master@{#396282}
Patch Set 1 #
Total comments: 2
Dependent Patchsets: Messages
Total messages: 17 (6 generated)
Description was changed from ========== Whitelist Hangouts, including Chromebox for Meetings, for ChromeVox Next BUG=605788 ========== to ========== Whitelist Hangouts, including Chromebox for Meetings, for ChromeVox Next BUG=605788 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
dmazzoni@chromium.org changed reviewers: + dtseng@chromium.org
Cl seems fine, but how does it fix the referenced bug?
Description was changed from ========== Whitelist Hangouts, including Chromebox for Meetings, for ChromeVox Next BUG=605788 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Whitelist Hangouts, including Chromebox for Meetings, for ChromeVox Next BUG=613694 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Updated to the meta bug for all Buddy / CFM / Hangouts issues
Friendly ping, can I have an actually l g t m for this? When all of the current changes out for review land it should be quite usable
Friendly ping, can I have an actually l g t m for this? When all of the current changes out for review land it should be quite usable
https://codereview.chromium.org/1998033004/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 (right): https://codereview.chromium.org/1998033004/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2:36: "https://talkgadget.google.com/hangouts*" Would this impact injection of Classic into hangouts iframes?
https://codereview.chromium.org/1998033004/diff/1/chrome/browser/resources/ch... File chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 (right): https://codereview.chromium.org/1998033004/diff/1/chrome/browser/resources/ch... chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2:36: "https://talkgadget.google.com/hangouts*" On 2016/05/26 19:24:58, David Tseng wrote: > Would this impact injection of Classic into hangouts iframes? Doesn't seem to be the same url pattern, seems safe
lgtm
The CQ bit was checked by dmazzoni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998033004/1
Message was sent while issue was closed.
Description was changed from ========== Whitelist Hangouts, including Chromebox for Meetings, for ChromeVox Next BUG=613694 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Whitelist Hangouts, including Chromebox for Meetings, for ChromeVox Next BUG=613694 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Whitelist Hangouts, including Chromebox for Meetings, for ChromeVox Next BUG=613694 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Whitelist Hangouts, including Chromebox for Meetings, for ChromeVox Next BUG=613694 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/69cc7b82b9db14e2eb2d3a78299ffa3a8dbcdbb7 Cr-Commit-Position: refs/heads/master@{#396282} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/69cc7b82b9db14e2eb2d3a78299ffa3a8dbcdbb7 Cr-Commit-Position: refs/heads/master@{#396282} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
