Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2002693002: Automation API should use transforms for iframe coordinates. (Closed)

Created:
4 years, 7 months ago by dmazzoni
Modified:
4 years, 7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Automation API should use transforms for iframe coordinates. ChromeVox wasn't getting the right coordinates for some objects inside of iframes or webviews. Update the automation API bindings to use the new coordinate calculation logic that's based on matrix transforms rather than offsets. BUG=551601 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3d2f3d2c1cedc166a5a9a74d5e4837e4be9c1f6a Cr-Commit-Position: refs/heads/master@{#395651}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : No dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 1 chunk +19 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dmazzoni
4 years, 7 months ago (2016-05-20 18:54:59 UTC) #3
dmazzoni
Friendly ping https://codereview.chromium.org/2002693002/diff/1/chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 File chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 (right): https://codereview.chromium.org/2002693002/diff/1/chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2#newcode36 chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2:36: "https://talkgadget.google.com/hangouts*" Ignore this, this was merged in ...
4 years, 7 months ago (2016-05-23 23:13:40 UTC) #4
David Tseng
lgtm
4 years, 7 months ago (2016-05-23 23:32:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002693002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002693002/40001
4 years, 7 months ago (2016-05-24 17:05:31 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-24 18:47:32 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 18:50:25 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3d2f3d2c1cedc166a5a9a74d5e4837e4be9c1f6a
Cr-Commit-Position: refs/heads/master@{#395651}

Powered by Google App Engine
This is Rietveld 408576698