Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1997993003:
Add support for Jessie ARM64 sysroot (Closed)
DescriptionAdd support for Jessie ARM64 sysroot
This change modifies sysroot creation scripts to be able to build
sysroot for ARM64 Linux.
BUG=613452
Committed: https://crrev.com/52f5e999bf2a3700d8f22b13121f27aebc60b1a3
Cr-Commit-Position: refs/heads/master@{#396892}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Incorporating review comments #Patch Set 3 : Forgot to sort DEBIAN_PACKAGES_X86 variable in last patch set #
Messages
Total messages: 27 (9 generated)
Description was changed from ========== Add support for Jessie ARM64 sysroot This change modifies sysroot creation sysripts to be able to build sysroot for ARM64 Linux. BUG=613452 ========== to ========== Add support for Jessie ARM64 sysroot This change modifies sysroot creation sysripts to be able to build sysroot for ARM64 Linux. BUG=613452 ==========
apatole@nvidia.com changed reviewers: + mmoss@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org
On 2016/05/24 06:26:20, apatole wrote: > mailto:apatole@nvidia.com changed reviewers: > + mailto:mmoss@chromium.org, mailto:phajdan.jr@chromium.org, mailto:thestig@chromium.org Hi Reviewers, let me know if you have any comments.
Description was changed from ========== Add support for Jessie ARM64 sysroot This change modifies sysroot creation sysripts to be able to build sysroot for ARM64 Linux. BUG=613452 ========== to ========== Add support for Jessie ARM64 sysroot This change modifies sysroot creation scripts to be able to build sysroot for ARM64 Linux. BUG=613452 ==========
Description was changed from ========== Add support for Jessie ARM64 sysroot This change modifies sysroot creation scripts to be able to build sysroot for ARM64 Linux. BUG=613452 ========== to ========== Add support for Jessie ARM64 sysroot This change modifies sysroot creation scripts to be able to build sysroot for ARM64 Linux. BUG=613452 ==========
https://codereview.chromium.org/1997993003/diff/1/build/linux/sysroot_scripts... File build/linux/sysroot_scripts/sysroot-creator-jessie.sh (right): https://codereview.chromium.org/1997993003/diff/1/build/linux/sysroot_scripts... build/linux/sysroot_scripts/sysroot-creator-jessie.sh:221: libitm1 Would you mind sorting this in alphabetical order, and the two variables above it?
On 2016/05/27 21:04:47, Lei Zhang wrote: > https://codereview.chromium.org/1997993003/diff/1/build/linux/sysroot_scripts... > File build/linux/sysroot_scripts/sysroot-creator-jessie.sh (right): > > https://codereview.chromium.org/1997993003/diff/1/build/linux/sysroot_scripts... > build/linux/sysroot_scripts/sysroot-creator-jessie.sh:221: libitm1 > Would you mind sorting this in alphabetical order, and the two variables above > it? Thanks, Done.
The CQ bit was checked by thestig@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997993003/40001
The CQ bit was unchecked by commit-bot@chromium.org
The author apatole@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
On 2016/05/30 19:19:12, commit-bot: I haz the power wrote: > The author mailto:apatole@nvidia.com has not signed Google Contributor License > Agreement. Please visit https://cla.developers.google.com to sign and manage > CLA. Just got added to required NVIDIA contributor group, will try to commit the patch now.
The CQ bit was checked by apatole@nvidia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997993003/40001
Message was sent while issue was closed.
Description was changed from ========== Add support for Jessie ARM64 sysroot This change modifies sysroot creation scripts to be able to build sysroot for ARM64 Linux. BUG=613452 ========== to ========== Add support for Jessie ARM64 sysroot This change modifies sysroot creation scripts to be able to build sysroot for ARM64 Linux. BUG=613452 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add support for Jessie ARM64 sysroot This change modifies sysroot creation scripts to be able to build sysroot for ARM64 Linux. BUG=613452 ========== to ========== Add support for Jessie ARM64 sysroot This change modifies sysroot creation scripts to be able to build sysroot for ARM64 Linux. BUG=613452 Committed: https://crrev.com/52f5e999bf2a3700d8f22b13121f27aebc60b1a3 Cr-Commit-Position: refs/heads/master@{#396892} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/52f5e999bf2a3700d8f22b13121f27aebc60b1a3 Cr-Commit-Position: refs/heads/master@{#396892}
Message was sent while issue was closed.
Sorry, just now saw this. Why do we have a wheezy sysroot for everything (including arm64 android builds) but a jessie sysroot for amd64 linux?
Message was sent while issue was closed.
On 2016/06/02 17:59:00, Nico wrote: > Sorry, just now saw this. Why do we have a wheezy sysroot for everything > (including arm64 android builds) but a jessie sysroot for amd64 linux? Hi, thanks for your review! "amd64 linux" - I think you mean arm64 here? I saw support for jessie is already there in sysroot scripts. And so added support for jessie arm64 as well since it is the latest stable debian release. If required, we can also add support arm64 linux in wheezy sysroot scripts. But should it really be required? Since we are starting to add support for AMR64 linux first times, I think it makes sense to start with latest stable release. And eventually all other sysroots will also have to be moved to jessie as wheezy is now obsolete. Let me know if you still think we should have wheezy sysroot for arm64 linux.
Message was sent while issue was closed.
One more observation regarding arm64 sysroot, It seems debian started supporting arm64 only Jessie onwards. Support for arm64 was released first time with Jessie - https://wiki.debian.org/Arm64Port Before discovering above, I was just trying to build arm64 wheezy susroot but got errors. It did not find Package.gz/xz archive at https://http.us.debian.org/debian at path "wheezy/main/binary-arm64" and I found it is available only at path "jessie/main/binary-arm64"
Message was sent while issue was closed.
I'm not super familiar with sysroots, but for android arm64 builds we have a wheezy sysroot as far as I know, and for all other target archs we currently use wheezy too. It's true that we need to upgrade at some point, but I think it's better if all sysroots are on the same version and update all at once. (Lei, does that make sense? Do you disagree with that?)
Message was sent while issue was closed.
On 2016/06/04 01:15:45, Nico wrote: > I'm not super familiar with sysroots, but for android arm64 builds we have a > wheezy sysroot as far as I know Debian/wheezy was released before arm64 was generally available. The first Debian release with arm64 was Jessie. I think the android builds use the host architecture sysroots (i386 and amd64) rather than target? > , and for all other target archs we currently use > wheezy too. It's true that we need to upgrade at some point, but I think it's > better if all sysroots are on the same version and update all at once. (Lei, > does that make sense? Do you disagree with that?) If you build x86/amd64 chrome against Debian Jessie sysroot, chrome binaries no longer work on distributions older than Jessie (older than 2015). On arm64 this is not a problem, since older distributions than jessie on arm64 were rather beta/preview quality.
Message was sent while issue was closed.
Hi Lie/Nico, Let me know do you think? Let me know if you are OK to have Jessie sysroot for arm64 linux with the above explanations and then I can go ahead with committing another patch that uses this Jessie sysroot. Otherwise I can investigate more on this.
Message was sent while issue was closed.
On 2016/06/08 06:14:52, apatole wrote: > Hi Lie/Nico, > Let me know do you think? Let me know if you are OK to have Jessie sysroot for > arm64 linux with the above explanations and then I can go ahead with committing > another patch that uses this Jessie sysroot. Otherwise I can investigate more on > this. Thanks Nico and Riku for your inputs. I have now committed another patch which was dependent on this - https://codereview.chromium.org/2001523002. I will now work on modifying install script to automatically install arm64 sysroot. But will need help from someone in Google to upload it to the google cloud, will provide details on the tracking bug.
Message was sent while issue was closed.
On 2016/06/04 01:15:45, Nico (traveling...slow) wrote: > I'm not super familiar with sysroots, but for android arm64 builds we have a > wheezy sysroot as far as I know, and for all other target archs we currently use > wheezy too. It's true that we need to upgrade at some point, but I think it's > better if all sysroots are on the same version and update all at once. (Lei, > does that make sense? Do you disagree with that?) Sorry for the late reply. sbc@ and I looked at upgrading sysroot but decided we wanted our bots to be upgraded off of Ubuntu Precise first. We've been nagging Chrome Infrastructure folks to get going on that. It would be nice to have all the sysroots be the same version, and I believe we will get there eventually. But in the mean time, if Jessie is the first version with ARM64 support, and ARM64 is a community supported, best effort thing, I'm ok with the discrepancy. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
