third_party/WebKit/Source/core/fetch/RawResource.cpp - Issue 1997833002: Don't keep a separate m_revalidatingRequest on Resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/RawResource.cpp

Issue 1997833002: Don't keep a separate m_revalidatingRequest on Resource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp ('K') | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.h » ('j') | third_party/WebKit/Source/core/fetch/Resource.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/RawResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/RawResource.cpp b/third_party/WebKit/Source/core/fetch/RawResource.cpp

index 37c225d31083b9380e64516edee3504b4d1296fc..4a32cf95528e250e84348182ba438409b3dfeede 100644

--- a/third_party/WebKit/Source/core/fetch/RawResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/RawResource.cpp

@@ -144,7 +144,7 @@ void RawResource::willNotFollowRedirect()

void RawResource::responseReceived(const ResourceResponse& response, PassOwnPtr<WebDataConsumerHandle> handle)

{

- bool isSuccessfulRevalidation = isCacheValidator() && response.httpStatusCode() == 304;

+ bool isSuccessfulRevalidation = m_isRevalidating && response.httpStatusCode() == 304;

Resource::responseReceived(response, nullptr);

ResourceClientWalker<RawResourceClient> w(m_clients);