Don't keep a separate m_revalidatingRequest on Resource

third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp

Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
index bc4fef05fec3eb30296e4ba499cc3924809bf2cc..9f84f52d299ace29b3aa90c510849078bb02be0d 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
@@ -653,13 +653,6 @@ bool ScriptStreamer::startStreamingInternal(PendingScript* script, Type scriptTy
         recordNotStreamingReasonHistogram(scriptType, NotHTTP);
         return false;
     }
-    if (resource->isCacheValidator()) {

[Nate Chapin, 2016/05/19 22:18:38]

I think this this was a cache for the old way of revalidating with a separate
resource. I can't find any tests that indicate it's still needed.

[yhirano, 2016/05/23 11:40:38]

It seems this branch was introduced at
https://codereview.chromium.org/368283002#msg11, but I still don't understand
why it was needed and why it isn't needed any more. I'll try again tomorrow.

[yhirano, 2016/05/24 11:18:51]

I think this branch is needed because ScriptResource doesn't call
notifyAppendData when the revalidation succeeds.

I couldn't find any layout tests testing ScriptStreamer specifically by the way
(I skimmed ScriptStream.cpp changes but none of them updated LayoutTests except
https://codereview.chromium.org/1807193003).

[Nate Chapin, 2016/05/26 21:43:02]

Ok, the lack of tests is annoying, but I agree that the lack of
notifyAppendData() calls is a plausible reason, so I'm reverting this block.
That may be something to think about if we refactor ResourceClient callbacks at
some point.

-        recordNotStreamingReasonHistogram(scriptType, Reload);
-        // This happens e.g., during reloads. We're actually not going to load
-        // the current Resource of the PendingScript but switch to another
-        // Resource -> don't stream.
-        return false;
-    }
     // We cannot filter out short scripts, even if we wait for the HTTP headers
     // to arrive: the Content-Length HTTP header is not sent for chunked
     // downloads.