[Remoting Android] Put Icons and Credits on Navigation Menu

[Remoting Android] Put Icons and Credits on Navigation Menu

* Add icon to match the design of the account switcher.
* Add Credits on the navigation menu.

BUG=548929
Committed: https://crrev.com/a217e5a71255f8adc60f491ce4bf6b5cacad564b
Cr-Commit-Position: refs/heads/master@{#394998}

[Yuwei, 2016-05-20 01:16:03]

Patchset #2 (id:20001) has been deleted

[Yuwei, 2016-05-20 01:16:09]

Patchset #1 (id:1) has been deleted

[Yuwei, 2016-05-20 01:20:04]

Patchset #1 (id:40001) has been deleted

[Yuwei, 2016-05-20 01:20:48]

Description was changed from

==========
[Remoting Android] Put Icons and Credits on Navigation Menu

WIP

* Add icon to match the design of the account switcher.
* Add Credits on the navigation menu.

BUG=548929
==========

to

==========
[Remoting Android] Put Icons and Credits on Navigation Menu

* Add icon to match the design of the account switcher.
* Add Credits on the navigation menu.

BUG=548929
==========

[Yuwei, 2016-05-20 01:21:48]

yuweih@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Yuwei, 2016-05-20 01:21:49]

ptal. BTW all the XML files should be new files. Not sure why the code review
board believes it is copied from some other file...

[Yuwei, 2016-05-20 01:28:44]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 01:29:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997793002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997793002/60001

[Lambros, 2016-05-20 01:39:26]

lgtm

https://codereview.chromium.org/1997793002/diff/60001/remoting/android/java/s...
File
remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java
(right):

https://codereview.chromium.org/1997793002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java:15:
* Describes the appearance and behavior of the navigation menu. Please set this
to both Adapter and
For the second sentence, maybe say:
This also implements AdapterView.OnItemClickListener so it can be used as the
ListView's onItemClickListener.

[commit-bot: I haz the power, 2016-05-20 02:51:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 02:51:55]

Dry run: This issue passed the CQ dry run.

[Yuwei, 2016-05-20 03:13:52]

https://codereview.chromium.org/1997793002/diff/60001/remoting/android/java/s...
File
remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java
(right):

https://codereview.chromium.org/1997793002/diff/60001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java:15:
* Describes the appearance and behavior of the navigation menu. Please set this
to both Adapter and
On 2016/05/20 01:39:25, Lambros wrote:
> For the second sentence, maybe say:
> This also implements AdapterView.OnItemClickListener so it can be used as the
> ListView's onItemClickListener.

Done.

[Yuwei, 2016-05-20 03:14:00]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2016-05-20 03:14:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/1997793002/#ps80001
(title: "Reviewer's Feedback")

[commit-bot: I haz the power, 2016-05-20 03:14:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997793002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997793002/80001

[commit-bot: I haz the power, 2016-05-20 04:32:33]

Description was changed from

==========
[Remoting Android] Put Icons and Credits on Navigation Menu

* Add icon to match the design of the account switcher.
* Add Credits on the navigation menu.

BUG=548929
==========

to

==========
[Remoting Android] Put Icons and Credits on Navigation Menu

* Add icon to match the design of the account switcher.
* Add Credits on the navigation menu.

BUG=548929
==========

[commit-bot: I haz the power, 2016-05-20 04:32:34]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-05-20 04:34:04]

Description was changed from

==========
[Remoting Android] Put Icons and Credits on Navigation Menu

* Add icon to match the design of the account switcher.
* Add Credits on the navigation menu.

BUG=548929
==========

to

==========
[Remoting Android] Put Icons and Credits on Navigation Menu

* Add icon to match the design of the account switcher.
* Add Credits on the navigation menu.

BUG=548929

Committed: https://crrev.com/a217e5a71255f8adc60f491ce4bf6b5cacad564b
Cr-Commit-Position: refs/heads/master@{#394998}
==========

[commit-bot: I haz the power, 2016-05-20 04:34:06]

Patchset 2 (id:??) landed as
https://crrev.com/a217e5a71255f8adc60f491ce4bf6b5cacad564b
Cr-Commit-Position: refs/heads/master@{#394998}