Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: remoting/android/java/res/menu/credits_list_item.xml

Issue 1997793002: [Remoting Android] Put Icons and Credits on Navigation Menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's Feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/res/menu/credits_list_item.xml
diff --git a/chrome/android/java/res/layout/infobar_control_spinner_drop_down.xml b/remoting/android/java/res/menu/credits_list_item.xml
similarity index 53%
copy from chrome/android/java/res/layout/infobar_control_spinner_drop_down.xml
copy to remoting/android/java/res/menu/credits_list_item.xml
index 1b5222c14b983af66a51a1e4b1d69c38940073cd..768bc32bd4f8dc41725db267ac6112bdc315c54c 100644
--- a/chrome/android/java/res/layout/infobar_control_spinner_drop_down.xml
+++ b/remoting/android/java/res/menu/credits_list_item.xml
@@ -1,17 +1,18 @@
<?xml version="1.0" encoding="utf-8"?>
-
<!-- Copyright 2016 The Chromium Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
<TextView xmlns:android="http://schemas.android.com/apk/res/android"
- android:id="@+id/control_spinner_drop_down"
- android:layout_width="match_parent"
+ android:drawablePadding="32dp"
+ android:drawableStart="@drawable/ic_info"
+ android:gravity="center_vertical"
android:layout_height="wrap_content"
- android:layout_marginTop="10dp"
- android:layout_marginBottom="10dp"
- android:background="?android:attr/selectableItemBackground"
- android:ellipsize="end"
- android:padding="10dp"
- android:singleLine="true" />
+ android:layout_width="match_parent"
+ android:paddingStart="16dp"
+ android:paddingEnd="16dp"
+ android:paddingTop="16dp"
+ android:paddingBottom="20dp"
+ android:text="@string/credits"
+ style="@style/NavigationTextStyle"/>
« no previous file with comments | « remoting/android/java/res/layout/navigation_list.xml ('k') | remoting/android/java/res/menu/help_list_item.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698