content/browser/media/session/media_session_visibility_browsertest.cc - Issue 1997783002: Revert "Flip unified media pipeline to default-on w/ disabled holdback."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/session/media_session_visibility_browsertest.cc

Issue 1997783002: Revert "Flip unified media pipeline to default-on w/ disabled holdback." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/media_canplaytype_browsertest.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/session/media_session_visibility_browsertest.cc

diff --git a/content/browser/media/session/media_session_visibility_browsertest.cc b/content/browser/media/session/media_session_visibility_browsertest.cc

index f83cd8580812f46de3cc90c8bfa6f28bd75ef128..30cea46075055a4ab8d805cbbd7529905add48de 100644

--- a/content/browser/media/session/media_session_visibility_browsertest.cc

+++ b/content/browser/media/session/media_session_visibility_browsertest.cc

@@ -196,6 +196,7 @@ class MediaSessionVisibilityBrowserTest_UnifiedPipeline_SuspendOnHide :

public MediaSessionVisibilityBrowserTest {

void SetUpCommandLine(base::CommandLine* command_line) override {

MediaSessionVisibilityBrowserTest::SetUpCommandLine(command_line);

+ command_line->AppendSwitch(switches::kEnableUnifiedMediaPipeline);

#if !defined(OS_ANDROID)

command_line->AppendSwitch(switches::kEnableMediaSuspend);

#endif // defined(OS_ANDROID)

@@ -214,6 +215,7 @@ class MediaSessionVisibilityBrowserTest_UnifiedPipeline_NosuspendOnHide :

public MediaSessionVisibilityBrowserTest {

void SetUpCommandLine(base::CommandLine* command_line) override {

MediaSessionVisibilityBrowserTest::SetUpCommandLine(command_line);

+ command_line->AppendSwitch(switches::kEnableUnifiedMediaPipeline);

#if defined(OS_ANDROID)

command_line->AppendSwitch(switches::kDisableMediaSuspend);

#endif // defined(OS_ANDROID)

@@ -233,7 +235,6 @@ class MediaSessionVisibilityBrowserTest_AndroidPipeline_SuspendOnHide :

public MediaSessionVisibilityBrowserTest {

void SetUpCommandLine(base::CommandLine* command_line) override {

MediaSessionVisibilityBrowserTest::SetUpCommandLine(command_line);

- command_line->AppendSwitch(switches::kDisableUnifiedMediaPipeline);

}

};

@@ -249,7 +250,6 @@ class MediaSessionVisibilityBrowserTest_AndroidPipeline_NosuspendOnHide :

public MediaSessionVisibilityBrowserTest {

void SetUpCommandLine(base::CommandLine* command_line) override {

MediaSessionVisibilityBrowserTest::SetUpCommandLine(command_line);

- command_line->AppendSwitch(switches::kDisableUnifiedMediaPipeline);

command_line->AppendSwitch(switches::kDisableMediaSuspend);

}

};