Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1997783002: Revert "Flip unified media pipeline to default-on w/ disabled holdback." (Closed)

Created:
4 years, 7 months ago by DaleCurtis
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Revert "Flip unified media pipeline to default-on w/ disabled holdback." This reverts commit 7defc181e284d5e24a00a9254d4dc7ac3f2c15cb and makes the unified media pipeline disabled by default on M51. BUG=613238, 533190 R=liberato@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/0bc1fd7f212cf3f7223500ae7016d946f24ee934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -57 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 9 chunks +51 lines, -32 lines 0 comments Download
M content/browser/media/session/media_session_visibility_browsertest.cc View 4 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_switches.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
DaleCurtis
4 years, 7 months ago (2016-05-19 19:01:13 UTC) #2
liberato (no reviews please)
switching the interpretation of the flag from enabled to disabled and back to enabled is ...
4 years, 7 months ago (2016-05-19 20:23:22 UTC) #4
watk
lgtm
4 years, 7 months ago (2016-05-19 20:24:02 UTC) #6
DaleCurtis
Prefer this otherwise users can't enable it via flags.
4 years, 7 months ago (2016-05-19 20:24:17 UTC) #8
DaleCurtis
4 years, 7 months ago (2016-05-19 20:26:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0bc1fd7f212cf3f7223500ae7016d946f24ee934 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698