Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1997773002: Retract GrRenderTarget from GLProgramsTest (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Retract GrRenderTarget from GLProgramsTest Split out of https://codereview.chromium.org/1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1997773002 Committed: https://skia.googlesource.com/skia/+/82ec6e59b8b694c128adcf8590667d37327dd1c4

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -57 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/GrProcessorUnitTest.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 4 chunks +51 lines, -52 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 7 months ago (2016-05-19 19:38:02 UTC) #4
bsalomon
lgtm
4 years, 7 months ago (2016-05-19 19:48:32 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997773002/20001
4 years, 7 months ago (2016-05-19 20:41:01 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 20:59:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997773002/20001
4 years, 7 months ago (2016-05-19 20:59:52 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 21:01:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/82ec6e59b8b694c128adcf8590667d37327dd1c4

Powered by Google App Engine
This is Rietveld 408576698