Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 19977003: drawBitmap* cleanup (Closed)

Created:
7 years, 5 months ago by robertphillips
Modified:
7 years, 5 months ago
Reviewers:
edisonn, bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This CL cleans up the drawBitmap* call stack a bit in preparation for the "bleed" change; it: folds SkCanvas::commonDrawBitmap into internalDrawbitmap (its only caller) removes the 'srcRect' parameter from SkCanvas::internalDrawbitmap (since it was always NULL) removes the 'srcRectOrNull' parameter from SkDevice::drawBitmap (and derived classes) since it was always NULL makes a minor change to SkGpuDevice::internalDrawBitmap to only perform checks to turn off the texture domain if it was turned on in the first place

Patch Set 1 #

Patch Set 2 : Fixed bugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -90 lines) Patch
M include/core/SkCanvas.h View 1 3 chunks +4 lines, -9 lines 0 comments Download
M include/core/SkDevice.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M include/device/xps/SkXPSDevice.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/SkGpuDevice.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M include/pdf/SkPDFDevice.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 4 chunks +14 lines, -18 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 chunks +2 lines, -12 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 2 chunks +2 lines, -14 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 5 chunks +11 lines, -24 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 2 chunks +4 lines, -6 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
7 years, 5 months ago (2013-07-24 17:02:19 UTC) #1
edisonn
LGTM the pdf stuff
7 years, 5 months ago (2013-07-24 17:16:31 UTC) #2
bsalomon
On 2013/07/24 17:16:31, edisonn wrote: > LGTM the pdf stuff gpu lgtm
7 years, 5 months ago (2013-07-24 17:19:42 UTC) #3
reed1
did you find all of the canvas subclasses? I guess the compiler would have told ...
7 years, 5 months ago (2013-07-24 18:32:47 UTC) #4
robertphillips
On 2013/07/24 18:32:47, reed1 wrote: > did you find all of the canvas subclasses? I ...
7 years, 5 months ago (2013-07-24 18:48:01 UTC) #5
robertphillips
7 years, 5 months ago (2013-07-25 12:11:53 UTC) #6
committed as r10342

Powered by Google App Engine
This is Rietveld 408576698