Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(160)

Issue 1997603002: libvpx: add configurations excluding VP9 for ARM Neon and ARM64. (Closed)

Created:
1 year, 11 months ago by kjellander_chromium
Modified:
6 months, 3 weeks ago
Reviewers:
wwcv, Johann
CC:
chromium-reviews, wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libvpx: add configurations excluding VP9 for ARM Neon and ARM64. This generates configuration files that can be used in cases when VP9 is not desired due to binary size constraints. BUG=612174 TESTED=Successfully executed: cd third_party/libvpx mkdir source/config/linux/arm-neon-no-vp9 mkdir source/config/linux/arm64-no-vp9 ./generate_gypi.sh

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+658 lines, -628 lines) Patch
M third_party/libvpx/generate_gypi.sh View 5 chunks +18 lines, -0 lines 2 comments Download
M third_party/libvpx/libvpx_srcs.gni View 2 chunks +474 lines, -0 lines 0 comments Download
A + third_party/libvpx/libvpx_srcs_arm64_no_vp9.gypi View 4 chunks +0 lines, -161 lines 0 comments Download
M third_party/libvpx/libvpx_srcs_arm_neon_cpu_detect_intrinsics.gypi View 1 chunk +0 lines, -35 lines 2 comments Download
A + third_party/libvpx/libvpx_srcs_arm_neon_no_vp9.gypi View 5 chunks +0 lines, -162 lines 0 comments Download
A + third_party/libvpx/source/config/linux/arm-neon-no-vp9/vp8_rtcd.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/libvpx/source/config/linux/arm-neon-no-vp9/vp9_rtcd.h View 1 chunk +77 lines, -0 lines 1 comment Download
A + third_party/libvpx/source/config/linux/arm-neon-no-vp9/vpx_config.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/libvpx/source/config/linux/arm-neon-no-vp9/vpx_config.asm View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/libvpx/source/config/linux/arm-neon-no-vp9/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/libvpx/source/config/linux/arm-neon-no-vp9/vpx_dsp_rtcd.h View 7 chunks +0 lines, -123 lines 0 comments Download
A + third_party/libvpx/source/config/linux/arm-neon-no-vp9/vpx_scale_rtcd.h View 1 chunk +0 lines, -6 lines 0 comments Download
A + third_party/libvpx/source/config/linux/arm64-no-vp9/vp8_rtcd.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/libvpx/source/config/linux/arm64-no-vp9/vp9_rtcd.h View 1 chunk +77 lines, -0 lines 0 comments Download
A + third_party/libvpx/source/config/linux/arm64-no-vp9/vpx_config.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/libvpx/source/config/linux/arm64-no-vp9/vpx_config.asm View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/libvpx/source/config/linux/arm64-no-vp9/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/libvpx/source/config/linux/arm64-no-vp9/vpx_dsp_rtcd.h View 7 chunks +0 lines, -123 lines 0 comments Download
A + third_party/libvpx/source/config/linux/arm64-no-vp9/vpx_scale_rtcd.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
kjellander_chromium
This is essentially what I meant in https://bugs.chromium.org/p/chromium/issues/detail?id=612174 there's no need to commit this any ...
1 year, 11 months ago (2016-05-19 08:48:15 UTC) #2
Johann
1 year, 11 months ago (2016-05-24 20:13:39 UTC) #4
The cpu thing is weird but otherwise it LGTM. Not sure how to modify
BUILD.gn/libvpx.gyp to make those targets available though

https://codereview.chromium.org/1997603002/diff/1/third_party/libvpx/generate...
File third_party/libvpx/generate_gypi.sh (right):

https://codereview.chromium.org/1997603002/diff/1/third_party/libvpx/generate...
third_party/libvpx/generate_gypi.sh:463: all_platforms="--enable-external-build
--enable-postproc --disable-install-srcs --enable-multi-res-encoding
--enable-temporal-denoising --disable-unit-tests --disable-install-docs
--disable-examples --enable-vp9-temporal-denoising --enable-vp9-postproc
--size-limit=16384x16384 $DISABLE_AVX --as=yasm"
On 2016/05/19 08:48:15, kjellander (chromium) wrote:
> Do I have to remove '--enable-vp9-temporal-denoising --enable-vp9-postproc'
when
> I do --disable-vp9 or are they just no-ops?
> It'll make the code harder to read if I move them out into a separate variable
> etc.

you can leave it, it is harmless.

https://codereview.chromium.org/1997603002/diff/1/third_party/libvpx/libvpx_s...
File third_party/libvpx/libvpx_srcs_arm_neon_cpu_detect_intrinsics.gypi (left):

https://codereview.chromium.org/1997603002/diff/1/third_party/libvpx/libvpx_s...
third_party/libvpx/libvpx_srcs_arm_neon_cpu_detect_intrinsics.gypi:16:
'<(libvpx_source)/vp8/common/arm/neon/bilinearpredict_neon.c',
On 2016/05/19 08:48:15, kjellander (chromium) wrote:
> When I run ./generate_gypi.sh from a clean checkout these changes also show
up,
> so they're not related to my CL. I guess a separate update CL is needed for
> these?

Hmm this looks very strange. cpu-detect is not used in Chromium so there may be
a bug in the configuration but this is odd.

https://codereview.chromium.org/1997603002/diff/1/third_party/libvpx/source/c...
File third_party/libvpx/source/config/linux/arm-neon-no-vp9/vp9_rtcd.h (right):

https://codereview.chromium.org/1997603002/diff/1/third_party/libvpx/source/c...
third_party/libvpx/source/config/linux/arm-neon-no-vp9/vp9_rtcd.h:1: #ifndef
VP9_RTCD_H_
Hmm this shouldn't get built but I think it's a weird side effect of how we
generate these files for chromium and not worth fixing.

Powered by Google App Engine
This is Rietveld 408576698