Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 1997583002: Revert of : Initialize and reset V4LocalDBManager. Instantiate V4Stores. (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of : Initialize and reset V4LocalDBManager. Instantiate V4Stores. (patchset #1 id:1 of https://codereview.chromium.org/1985263002/ ) Reason for revert: Actually revert looks fixed the problem, according to: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/48793 Therefore speculatively reverting again. Original issue's description: > Reland of land: Initialize and reset V4LocalDBManager. Instantiate V4Stores. (patchset #1 id:1 of https://codereview.chromium.org/1984283003/ ) > > Reason for revert: > Revert didn't help the problem (tests still failing as before on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29?numbuilds=50) > > Original issue's description: > > Revert of Reland: Initialize and reset V4LocalDBManager. Instantiate V4Stores. (patchset #6 id:100001 of https://codereview.chromium.org/1983723002/ ) > > > > Reason for revert: > > Speculative revert for http://crbug.com/612523; will re-land if that builder still fails the same tests after the revert > > > > Original issue's description: > > > Reland: Initialize and reset V4LocalDBManager. Instantiate V4Stores. > > > A rough sketch of how this works is here: https://goto.google.com/pver4-LoadUpdateDatabase-doc > > > > > > This relands https://codereview.chromium.org/1954393002 which was reverted by https://codereview.chromium.org/1983603002 > > > > > > Reason for failure: StopOnIOThread ran first and reset v4_update_protocol_manager_, which we were later tried to dereference in DatabaseReady() > > > > > > -- > > > Original commit: http://crrev.com/32b9468ab5177534cb155b2d222611a6bca16c98 > > > Which was reverted as: http://crrev.com/517133dfc95a9ca2b599bfe7452205e5b5d81fd4 > > > > > > This CL reverts commit http://crrev.com/517133dfc95a9ca2b599bfe7452205e5b5d81fd4 > > > -- > > > > > > BUG=543161 > > > > > > Committed: https://crrev.com/26771182e06d28496aca4c73e095d3c9a43713ce > > > Cr-Commit-Position: refs/heads/master@{#393989} > > > > TBR=shess@chromium.org,nparker@chromium.org,vakh@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=543161 > > > > Committed: https://crrev.com/ed2c1c1767e9eb657d804b32088ba141502b645e > > Cr-Commit-Position: refs/heads/master@{#394227} > > TBR=shess@chromium.org,nparker@chromium.org,vakh@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=543161 > > Committed: https://crrev.com/0c301ecdffa4dcd497a30661b716fb170a17c4d6 > Cr-Commit-Position: refs/heads/master@{#394257} TBR=shess@chromium.org,nparker@chromium.org,vakh@chromium.org,qyearsley@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=543161 Committed: https://crrev.com/6502eaa9685340bf823f0555d99fb169c9704867 Cr-Commit-Position: refs/heads/master@{#394712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -298 lines) Patch
M chrome/browser/safe_browsing/services_delegate_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M components/safe_browsing_db.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_browsing_db/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M components/safe_browsing_db/v4_database.h View 3 chunks +9 lines, -32 lines 0 comments Download
M components/safe_browsing_db/v4_database.cc View 1 chunk +10 lines, -72 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.h View 4 chunks +4 lines, -21 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 5 chunks +9 lines, -73 lines 0 comments Download
M components/safe_browsing_db/v4_store.h View 1 chunk +0 lines, -17 lines 0 comments Download
D components/safe_browsing_db/v4_store.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager.h View 4 chunks +3 lines, -8 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager.cc View 10 chunks +14 lines, -42 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hiroshige
Created Revert of : Initialize and reset V4LocalDBManager. Instantiate V4Stores.
4 years, 7 months ago (2016-05-19 07:15:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997583002/1
4 years, 7 months ago (2016-05-19 07:15:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997583002/1
4 years, 7 months ago (2016-05-19 07:31:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997583002/1
4 years, 7 months ago (2016-05-19 08:01:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 08:21:52 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 08:23:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6502eaa9685340bf823f0555d99fb169c9704867
Cr-Commit-Position: refs/heads/master@{#394712}

Powered by Google App Engine
This is Rietveld 408576698