Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1983603002: Revert of Initialize and reset V4LocalDBManager. Instantiate V4Stores. (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@v4_01_db_realz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Initialize and reset V4LocalDBManager. Instantiate V4Stores. (patchset #12 id:220001 of https://codereview.chromium.org/1954393002/ ) Reason for revert: Seems very likely to be the cause of Mac build failures: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg) Original issue's description: > Initialize and reset V4LocalDBManager. Instantiate V4Stores. > > A rough sketch of how this works is here: https://goto.google.com/pver4-LoadUpdateDatabase-doc > > BUG=543161 > > Committed: https://crrev.com/32b9468ab5177534cb155b2d222611a6bca16c98 > Cr-Commit-Position: refs/heads/master@{#393719} TBR=shess@chromium.org,nparker@chromium.org,vakh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=543161 Committed: https://crrev.com/517133dfc95a9ca2b599bfe7452205e5b5d81fd4 Cr-Commit-Position: refs/heads/master@{#393756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -279 lines) Patch
M chrome/browser/safe_browsing/services_delegate_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M components/safe_browsing_db.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_browsing_db/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M components/safe_browsing_db/v4_database.h View 3 chunks +9 lines, -28 lines 0 comments Download
M components/safe_browsing_db/v4_database.cc View 1 chunk +10 lines, -65 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.h View 4 chunks +4 lines, -21 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 5 chunks +9 lines, -65 lines 0 comments Download
M components/safe_browsing_db/v4_store.h View 1 chunk +0 lines, -17 lines 0 comments Download
D components/safe_browsing_db/v4_store.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager.h View 4 chunks +3 lines, -8 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager.cc View 10 chunks +14 lines, -42 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ken Rockot(use gerrit already)
Created Revert of Initialize and reset V4LocalDBManager. Instantiate V4Stores.
4 years, 7 months ago (2016-05-15 00:30:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983603002/1
4 years, 7 months ago (2016-05-15 00:31:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-15 00:31:48 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-15 00:33:36 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/517133dfc95a9ca2b599bfe7452205e5b5d81fd4
Cr-Commit-Position: refs/heads/master@{#393756}

Powered by Google App Engine
This is Rietveld 408576698