Fix "unused variable" warnings.

Fix "unused variable" warnings.

These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and
must be fixed before that change can land.

See https://codereview.chromium.org/1981053002/ for the full CL.

BUG=447156
TEST=none

Committed: https://crrev.com/28ae5793fe58479fc7a960860e08572c6578a701
Cr-Commit-Position: refs/heads/master@{#395173}

[Peter Kasting, 2016-05-19 05:11:36]

pkasting@chromium.org changed reviewers:
+ tedchoc@chromium.org, thestig@chromium.org

[Peter Kasting, 2016-05-19 05:11:37]

tedchoc: chrome/android/, chrome/browser/android/
thestig: rest

https://codereview.chromium.org/1997453003/diff/20001/chrome/browser/geolocat...
File chrome/browser/geolocation/geolocation_permission_context_extensions.cc
(right):

https://codereview.chromium.org/1997453003/diff/20001/chrome/browser/geolocat...
chrome/browser/geolocation/geolocation_permission_context_extensions.cc:25: #if
defined(ENABLE_EXTENSIONS)
I guess this worked before because the compiler treats undefined symbols as 0? 
In any case, using defined() matches every other instance in the codebase.

https://codereview.chromium.org/1997453003/diff/20001/chrome/browser/signin/s...
File chrome/browser/signin/signin_status_metrics_provider_chromeos_unittest.cc
(right):

https://codereview.chromium.org/1997453003/diff/20001/chrome/browser/signin/s...
chrome/browser/signin/signin_status_metrics_provider_chromeos_unittest.cc:13:
SigninStatusMetricsProviderChromeOS metrics_provider;
This was an interesting case.  The old code requires the copy constructor to be
accessible from this location, even though it's not actually called. 
SigninStatusMetricsProviderChromeOS uses DISALLOW_COPY_AND_ASSIGN, but the old
definition for that only makes that constructor private; since this test is a
friend, it can see that private declaration.  And since the copy constructor
isn't actually accessed, it doesn't matter that it's never defined.

Switching to "= delete" means the old code here won't compile.  Luckily, the fix
is easy.

[Lei Zhang, 2016-05-19 05:45:21]

looks ok, but there are red trybots.

[Peter Kasting, 2016-05-19 07:10:21]

On 2016/05/19 05:45:21, Lei Zhang wrote:
> looks ok, but there are red trybots.

Not anymore :)

[Lei Zhang, 2016-05-19 07:23:38]

On 2016/05/19 07:10:21, Peter Kasting wrote:
> On 2016/05/19 05:45:21, Lei Zhang wrote:
> > looks ok, but there are red trybots.
> 
> Not anymore :)

non-Android && non-components bits lgtm

[Peter Kasting, 2016-05-19 07:28:28]

pkasting@chromium.org changed reviewers:
+ rogerta@chromium.org

[Peter Kasting, 2016-05-19 07:28:28]

+rogerta for components/signin/

[Peter Kasting, 2016-05-20 18:42:57]

ping tedchoc/rogerta

[Roger Tawa OOO till Jul 10th, 2016-05-20 18:57:41]

lgtm comp/signin

[Ted C, 2016-05-20 20:24:26]

On 2016/05/20 18:57:41, Roger Tawa wrote:
> lgtm comp/signin

android - lgtm

[Peter Kasting, 2016-05-20 20:33:04]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-05-20 20:33:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1997453003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1997453003/40001

[commit-bot: I haz the power, 2016-05-20 21:39:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-20 21:41:01]

Description was changed from

==========
Fix "unused variable" warnings.

These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and
must be fixed before that change can land.

See https://codereview.chromium.org/1981053002/ for the full CL.

BUG=447156
TEST=none
==========

to

==========
Fix "unused variable" warnings.

These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and
must be fixed before that change can land.

See https://codereview.chromium.org/1981053002/ for the full CL.

BUG=447156
TEST=none

Committed: https://crrev.com/28ae5793fe58479fc7a960860e08572c6578a701
Cr-Commit-Position: refs/heads/master@{#395173}
==========

[commit-bot: I haz the power, 2016-05-20 21:41:03]

Patchset 3 (id:??) landed as
https://crrev.com/28ae5793fe58479fc7a960860e08572c6578a701
Cr-Commit-Position: refs/heads/master@{#395173}