Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1997423003: [Media Router] Remove MR FeatureSwitch's dependency on EAR. (Closed)

Created:
4 years, 7 months ago by imcheng
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Media Router] Remove MR FeatureSwitch's dependency on EAR. The ExtensionActionRedesign field trial expires after M51, and the feature is already enabled by default. We should remove MR's dependency on it. Also, remove media_router_with_cast_extension FeatureSwitch as it's no longer used. BUG=613252 Review-Url: https://codereview.chromium.org/1996123002 Cr-Commit-Position: refs/heads/master@{#395165} (cherry picked from commit 9013e165f40d23f8fd28424f157fa4bb3805d018) Committed: https://chromium.googlesource.com/chromium/src/+/94f2c95daa02e03ce1aef6f572abae74a857e8f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -161 lines) Patch
M chrome/common/extensions/feature_switch_unittest.cc View 10 chunks +34 lines, -84 lines 0 comments Download
M extensions/common/feature_switch.h View 4 chunks +4 lines, -11 lines 0 comments Download
M extensions/common/feature_switch.cc View 6 chunks +15 lines, -66 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
imcheng
4 years, 7 months ago (2016-05-23 20:17:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94f2c95daa02e03ce1aef6f572abae74a857e8f5.

Powered by Google App Engine
This is Rietveld 408576698