Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1996123002: [Media Router] Remove MR FeatureSwitch's dependency on EAR. (Closed)

Created:
4 years, 7 months ago by imcheng
Modified:
4 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Remove MR FeatureSwitch's dependency on EAR. The ExtensionActionRedesign field trial expires after M51, and the feature is already enabled by default. We should remove MR's dependency on it. Also, remove media_router_with_cast_extension FeatureSwitch as it's no longer used. BUG=613252 Committed: https://crrev.com/9013e165f40d23f8fd28424f157fa4bb3805d018 Cr-Commit-Position: refs/heads/master@{#395165}

Patch Set 1 #

Patch Set 2 : Remove multiple field trials' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -161 lines) Patch
M chrome/common/extensions/feature_switch_unittest.cc View 1 10 chunks +34 lines, -84 lines 0 comments Download
M extensions/common/feature_switch.h View 1 4 chunks +4 lines, -11 lines 0 comments Download
M extensions/common/feature_switch.cc View 1 6 chunks +15 lines, -66 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
imcheng
Devlin: PTAL. I left the option to specify multiple field trials in the code, but ...
4 years, 7 months ago (2016-05-19 18:54:56 UTC) #2
Devlin
On 2016/05/19 18:54:56, imcheng wrote: > Devlin: PTAL. I left the option to specify multiple ...
4 years, 7 months ago (2016-05-19 20:50:26 UTC) #3
imcheng
On 2016/05/19 20:50:26, Devlin wrote: > On 2016/05/19 18:54:56, imcheng wrote: > > Devlin: PTAL. ...
4 years, 7 months ago (2016-05-19 21:47:53 UTC) #4
Devlin
lgtm
4 years, 7 months ago (2016-05-20 20:03:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996123002/20001
4 years, 7 months ago (2016-05-20 20:07:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 21:09:00 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 21:10:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9013e165f40d23f8fd28424f157fa4bb3805d018
Cr-Commit-Position: refs/heads/master@{#395165}

Powered by Google App Engine
This is Rietveld 408576698