Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.cc

Issue 1997413002: Improve console message about deferring long-running timers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Chrome > Blink Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/components/scheduler/renderer/renderer_scheduler_impl.cc b/components/scheduler/renderer/renderer_scheduler_impl.cc
index 135cdabc2486402b877738d7df5b405f279ba045..5add212d251922ed56c12f00ebc0a7a214e913e9 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl.cc
@@ -1315,8 +1315,11 @@ void RendererSchedulerImpl::OnTriedToExecuteBlockedTask(
MainThreadOnly().have_reported_blocking_intervention_since_navigation =
true;
BroadcastConsoleWarning(
- "Deferred long-running timer task(s) to improve scrolling smoothness. "
- "See crbug.com/574343.");
+ "Blink deferred a task in order to make scrolling smoother. "
+ "Your timer tasks should take less than 50ms to run to avoid this. "
+ "Please see "
+ "https://developers.google.com/web/tools/chrome-devtools/profile/evaluate-performance/rail"
+ " and https://crbug.com/574343#c40 for more information.");
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698