Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: components/scheduler/renderer/renderer_scheduler_impl.cc

Issue 1997413002: Improve console message about deferring long-running timers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Chrome > Blink Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/renderer/renderer_scheduler_impl.h" 5 #include "components/scheduler/renderer/renderer_scheduler_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/debug/stack_trace.h" 8 #include "base/debug/stack_trace.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 1297 matching lines...) Expand 10 before | Expand all | Expand 10 after
1308 1308
1309 if (!MainThreadOnly().have_reported_blocking_intervention_since_navigation) { 1309 if (!MainThreadOnly().have_reported_blocking_intervention_since_navigation) {
1310 { 1310 {
1311 base::AutoLock lock(any_thread_lock_); 1311 base::AutoLock lock(any_thread_lock_);
1312 if (!AnyThread().have_seen_touchstart) 1312 if (!AnyThread().have_seen_touchstart)
1313 return; 1313 return;
1314 } 1314 }
1315 MainThreadOnly().have_reported_blocking_intervention_since_navigation = 1315 MainThreadOnly().have_reported_blocking_intervention_since_navigation =
1316 true; 1316 true;
1317 BroadcastConsoleWarning( 1317 BroadcastConsoleWarning(
1318 "Deferred long-running timer task(s) to improve scrolling smoothness. " 1318 "Blink deferred a task in order to make scrolling smoother. "
1319 "See crbug.com/574343."); 1319 "Your timer tasks should take less than 50ms to run to avoid this. "
1320 "Please see "
1321 "https://developers.google.com/web/tools/chrome-devtools/profile/evaluat e-performance/rail"
1322 " and https://crbug.com/574343#c40 for more information.");
1320 } 1323 }
1321 } 1324 }
1322 1325
1323 } // namespace scheduler 1326 } // namespace scheduler
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698