Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1997373002:
[turbofan] Simplify typed lowering of generator-related operators. (Closed)
Description[turbofan] Simplify typed lowering of generator-related operators.
Instead of changing existing nodes in a very fragile (and in one case expensive)
way, just create new ones instead.
Also properly chain effects, which was not done quite right before.
BUG=v8:4907
Committed: https://crrev.com/4579f28d72911ba6405a6a1b7e43ee7acd66a043
Cr-Commit-Position: refs/heads/master@{#36442}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
The CQ bit was checked by neis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997373002/1
Description was changed from ========== [turbofan] Simplify typed lowering of generator-related operators. Instead of changing existing nodes in a very fragile (and in one case expensive) way, just create new ones instead. Also properly chain effects, which was not done quite right before. BUG= ========== to ========== [turbofan] Simplify typed lowering of generator-related operators. Instead of changing existing nodes in a very fragile (and in one case expensive) way, just create new ones instead. Also properly chain effects, which was not done quite right before. BUG= ==========
neis@chromium.org changed reviewers: + jarin@chromium.org
Description was changed from ========== [turbofan] Simplify typed lowering of generator-related operators. Instead of changing existing nodes in a very fragile (and in one case expensive) way, just create new ones instead. Also properly chain effects, which was not done quite right before. BUG= ========== to ========== [turbofan] Simplify typed lowering of generator-related operators. Instead of changing existing nodes in a very fragile (and in one case expensive) way, just create new ones instead. Also properly chain effects, which was not done quite right before. BUG=v8:4907 ==========
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm; much nicer, thanks!
The CQ bit was checked by neis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997373002/1
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Simplify typed lowering of generator-related operators. Instead of changing existing nodes in a very fragile (and in one case expensive) way, just create new ones instead. Also properly chain effects, which was not done quite right before. BUG=v8:4907 ========== to ========== [turbofan] Simplify typed lowering of generator-related operators. Instead of changing existing nodes in a very fragile (and in one case expensive) way, just create new ones instead. Also properly chain effects, which was not done quite right before. BUG=v8:4907 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Simplify typed lowering of generator-related operators. Instead of changing existing nodes in a very fragile (and in one case expensive) way, just create new ones instead. Also properly chain effects, which was not done quite right before. BUG=v8:4907 ========== to ========== [turbofan] Simplify typed lowering of generator-related operators. Instead of changing existing nodes in a very fragile (and in one case expensive) way, just create new ones instead. Also properly chain effects, which was not done quite right before. BUG=v8:4907 Committed: https://crrev.com/4579f28d72911ba6405a6a1b7e43ee7acd66a043 Cr-Commit-Position: refs/heads/master@{#36442} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4579f28d72911ba6405a6a1b7e43ee7acd66a043 Cr-Commit-Position: refs/heads/master@{#36442}
Message was sent while issue was closed.
adamk@chromium.org changed reviewers: + adamk@chromium.org
Message was sent while issue was closed.
I suspect this CL is causing failures on the waterfall, in particular the arm64 nosnap debug builder. Here's the first failed build: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%... and it's been failing since then.
Message was sent while issue was closed.
On 2016/05/23 20:32:46, adamk wrote: > I suspect this CL is causing failures on the waterfall, in particular the arm64 > nosnap debug builder. Here's the first failed build: > > https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%... > > and it's been failing since then. Oops, looks like the failing test was just added in https://codereview.chromium.org/2002983002, so that's the actual "culprit" of this breakage. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
