Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 2002983002: [generators] Get better clusterfuzz coverage. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[generators] Get better clusterfuzz coverage. Duplicate mjsunit/harmony/generators.js but explicitly require --turbo-from-bytecode such that Clusterfuzz can thoroughly test the new generators implementation. BUG=v8:4907 Committed: https://crrev.com/0fd18acb9b891cf8a4703caf2e5d9eea971d83bd Cr-Commit-Position: refs/heads/master@{#36441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
A + test/mjsunit/harmony/generators-turbo.js View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
neis
ptal
4 years, 7 months ago (2016-05-23 11:43:22 UTC) #2
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-23 13:01:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002983002/1
4 years, 7 months ago (2016-05-23 13:27:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 13:57:08 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0fd18acb9b891cf8a4703caf2e5d9eea971d83bd Cr-Commit-Position: refs/heads/master@{#36441}
4 years, 7 months ago (2016-05-23 13:57:53 UTC) #8
adamk
4 years, 7 months ago (2016-05-23 20:41:19 UTC) #9
Message was sent while issue was closed.
This newly-added test is failing on arm64 nosnap debug:

https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

Powered by Google App Engine
This is Rietveld 408576698