Make favicon and manifest icon processing more consistent for add to homescreen.

Make favicon and manifest icon processing more consistent for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons are processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL is a first step in addressing the inconsistency by ensuring both
favicons and manifest icons are processed identically for add to
homescreen. The corner rounding is removed completely, while the
padding process is changed to only be applied on icons which have
nontransparent (alpha != 0) pixels in all four of their corners from either
source. This heuristic attempts to detect square icons with no existing
padding, which is often how favicons are produced. If any transparent
pixel in any corner is detected, no padding is applied.

A future CL will make the icon selection heuristic consistent between
favicons and manifest icons, which will complete the fix for this issue.

BUG=612028
Committed: https://crrev.com/96548fc8973a2e1fa7616d2de7fca20cbe5c98b6
Cr-Commit-Position: refs/heads/master@{#411494}

[dominickn, 2016-05-23 05:32:00]

Description was changed from

==========
Clip and pad manifest icons in the same way as favicons for add to homescreen.

Manifest icons were previously used as they were for add to homescreen
on Android, while favicons were processed to add rounded corners and
padding. This leads to inconsistent icon sizing when a site uses
a manifest to declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by passing manifest icons through the
same clipping and padding process as favicons for add to homescreen.

BUG=612028
==========

to

==========
Clip and pad manifest icons in the same way as favicons for add to homescreen.

Manifest icons were previously used as they were for add to homescreen
on Android, while favicons were processed to add rounded corners and
padding. This leads to inconsistent icon sizing when a site uses
a manifest to declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by passing manifest icons through the
same clipping and padding process as favicons for add to homescreen.

BUG=612028
==========

[dominickn, 2016-05-23 05:32:00]

dominickn@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[dominickn, 2016-05-23 05:32:32]

Description was changed from

==========
Clip and pad manifest icons in the same way as favicons for add to homescreen.

Manifest icons were previously used as they were for add to homescreen
on Android, while favicons were processed to add rounded corners and
padding. This leads to inconsistent icon sizing when a site uses
a manifest to declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by passing manifest icons through the
same clipping and padding process as favicons for add to homescreen.

BUG=612028
==========

to

==========
Clip and pad manifest icons in the same way as favicons for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons were processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by passing manifest icons through the
same clipping and padding process as favicons for add to homescreen.

BUG=612028
==========

[dominickn, 2016-05-23 06:20:12]

PTAL, thanks!

I've manually verified that this change corrects the icon inconsistency issue in
the bug, and produces icons of the same size whether they're taken from a
manifest or from the favicon.

I also ran clang-format over the file to fix up some indentation throughout.

[gone, 2016-05-23 19:55:15]

lgtm

yay for path unification

[mlamouri (slow - plz ping), 2016-05-23 22:02:09]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-05-23 22:02:10]

Can you hold before landing this. The Manifest doesn't follow the favicon path
for some reasons. Actually, there were discussions to no longer do rounding and
padding because web authors were sometimes not really happy about it (think of a
scare icon becoming rounded).

[dominickn, 2016-05-23 22:09:16]

On 2016/05/23 22:02:10, Mounir Lamouri (slow) wrote:
> Can you hold before landing this. The Manifest doesn't follow the favicon path
> for some reasons. Actually, there were discussions to no longer do rounding
and
> padding because web authors were sometimes not really happy about it (think of
a
> scare icon becoming rounded).

If that's the case, should I just remove the corner rounding and leave the
padding for both? I think that would solve the inconsistent sizing issue in this
bug

[mlamouri (slow - plz ping), 2016-05-23 22:11:22]

On 2016/05/23 at 22:09:16, dominickn wrote:
> On 2016/05/23 22:02:10, Mounir Lamouri (slow) wrote:
> > Can you hold before landing this. The Manifest doesn't follow the favicon
path
> > for some reasons. Actually, there were discussions to no longer do rounding
and
> > padding because web authors were sometimes not really happy about it (think
of a
> > scare icon becoming rounded).
> 
> If that's the case, should I just remove the corner rounding and leave the
padding for both? I think that would solve the inconsistent sizing issue in this
bug

I left a comment in the bug. Maybe we should discuss the issue there and come
back to this CL when we agree on a solution?

[dominickn, 2016-07-16 02:23:21]

Description was changed from

==========
Clip and pad manifest icons in the same way as favicons for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons were processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by passing manifest icons through the
same clipping and padding process as favicons for add to homescreen.

BUG=612028
==========

to

==========
Clip and pad manifest icons in the same way as favicons for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons were processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by removing the corner rounding from
favicons, and passing manifest icons through the same padding process
as favicons for add to homescreen.

BUG=612028
==========

[dominickn, 2016-07-18 00:50:33]

Description was changed from

==========
Clip and pad manifest icons in the same way as favicons for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons were processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by removing the corner rounding from
favicons, and passing manifest icons through the same padding process
as favicons for add to homescreen.

BUG=612028
==========

to

==========
Remove favicon corner rounding for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons were processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by removing the corner rounding from
favicons, and passing manifest icons through the same padding process
as favicons for add to homescreen.

BUG=612028
==========

[dominickn, 2016-07-18 00:51:22]

PTAL thanks! This now removes the corner rounding entirely for both favicons and
manifest icons as per the designer opinions in crbug.com/612028

[mlamouri (slow - plz ping), 2016-07-18 09:50:09]

Left a comment on the bug.

[dominickn, 2016-08-10 07:21:33]

Description was changed from

==========
Remove favicon corner rounding for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons were processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by removing the corner rounding from
favicons, and passing manifest icons through the same padding process
as favicons for add to homescreen.

BUG=612028
==========

to

==========
Make add to homescreen icon processing more consistent.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons were processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by removing the corner rounding from
favicons, and passing manifest icons through the same padding process
as favicons for add to homescreen. The padding process is changed to
only be applied on icons which have nontransparent (alpha != 0) pixels
in all four of their corners. This heuristic attempts to detect square
icons with no existing padding, which is often how favicons are
produced. If any transparent pixel in any corner is detected, no padding
is applied.

BUG=612028
==========

[dominickn, 2016-08-10 09:28:10]

Description was changed from

==========
Make add to homescreen icon processing more consistent.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons were processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL corrects the inconsistency by removing the corner rounding from
favicons, and passing manifest icons through the same padding process
as favicons for add to homescreen. The padding process is changed to
only be applied on icons which have nontransparent (alpha != 0) pixels
in all four of their corners. This heuristic attempts to detect square
icons with no existing padding, which is often how favicons are
produced. If any transparent pixel in any corner is detected, no padding
is applied.

BUG=612028
==========

to

==========
Make add to homescreen icon processing more consistent.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons are processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL is a first step in addressing the inconsistency by ensuring both
favicons and manifest icons are processed identically for add to
homescreen. The corner rounding is removed completely, while the
padding process is changed to only be applied on icons which have
nontransparent (alpha != 0) pixels in all four of their corners from either
source. This heuristic attempts to detect square icons with no existing
padding, which is often how favicons are produced. If any transparent
pixel in any corner is detected, no padding is applied.

A future CL will make the icon selection heuristic consistent between
favicons and manifest icons, which will complete the fix for this issue.

BUG=612028
==========

[dominickn, 2016-08-10 09:29:50]

PTAL, thanks!

[dominickn, 2016-08-10 09:30:20]

Description was changed from

==========
Make add to homescreen icon processing more consistent.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons are processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL is a first step in addressing the inconsistency by ensuring both
favicons and manifest icons are processed identically for add to
homescreen. The corner rounding is removed completely, while the
padding process is changed to only be applied on icons which have
nontransparent (alpha != 0) pixels in all four of their corners from either
source. This heuristic attempts to detect square icons with no existing
padding, which is often how favicons are produced. If any transparent
pixel in any corner is detected, no padding is applied.

A future CL will make the icon selection heuristic consistent between
favicons and manifest icons, which will complete the fix for this issue.

BUG=612028
==========

to

==========
Make favicon and manifest icon processing more consistent for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons are processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL is a first step in addressing the inconsistency by ensuring both
favicons and manifest icons are processed identically for add to
homescreen. The corner rounding is removed completely, while the
padding process is changed to only be applied on icons which have
nontransparent (alpha != 0) pixels in all four of their corners from either
source. This heuristic attempts to detect square icons with no existing
padding, which is often how favicons are produced. If any transparent
pixel in any corner is detected, no padding is applied.

A future CL will make the icon selection heuristic consistent between
favicons and manifest icons, which will complete the fix for this issue.

BUG=612028
==========

[gone, 2016-08-10 20:31:07]

Seems fine to me.  Most of the changes seemed to be cleanups.

lgtm

[dominickn, 2016-08-11 03:51:07]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 03:51:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 04:21:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 04:21:48]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-08-11 05:12:22]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 05:12:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-08-11 05:12:54]

On 2016/08/10 20:31:07, dfalcantara wrote:
> Seems fine to me.  Most of the changes seemed to be cleanups.
> 
> lgtm

Thanks!

mlamouri: any comments before I land this?

[commit-bot: I haz the power, 2016-08-11 05:56:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 05:56:40]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-08-11 08:48:23]

Sorry, I did not finish my round of review yesterday.

lgtm

[dominickn, 2016-08-12 00:48:33]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-08-12 00:48:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1997313002/#ps80001
(title: "Better variable naming")

[commit-bot: I haz the power, 2016-08-12 00:48:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 00:52:03]

Description was changed from

==========
Make favicon and manifest icon processing more consistent for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons are processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL is a first step in addressing the inconsistency by ensuring both
favicons and manifest icons are processed identically for add to
homescreen. The corner rounding is removed completely, while the
padding process is changed to only be applied on icons which have
nontransparent (alpha != 0) pixels in all four of their corners from either
source. This heuristic attempts to detect square icons with no existing
padding, which is often how favicons are produced. If any transparent
pixel in any corner is detected, no padding is applied.

A future CL will make the icon selection heuristic consistent between
favicons and manifest icons, which will complete the fix for this issue.

BUG=612028
==========

to

==========
Make favicon and manifest icon processing more consistent for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons are processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL is a first step in addressing the inconsistency by ensuring both
favicons and manifest icons are processed identically for add to
homescreen. The corner rounding is removed completely, while the
padding process is changed to only be applied on icons which have
nontransparent (alpha != 0) pixels in all four of their corners from either
source. This heuristic attempts to detect square icons with no existing
padding, which is often how favicons are produced. If any transparent
pixel in any corner is detected, no padding is applied.

A future CL will make the icon selection heuristic consistent between
favicons and manifest icons, which will complete the fix for this issue.

BUG=612028
==========

[commit-bot: I haz the power, 2016-08-12 00:52:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-12 00:55:22]

Description was changed from

==========
Make favicon and manifest icon processing more consistent for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons are processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL is a first step in addressing the inconsistency by ensuring both
favicons and manifest icons are processed identically for add to
homescreen. The corner rounding is removed completely, while the
padding process is changed to only be applied on icons which have
nontransparent (alpha != 0) pixels in all four of their corners from either
source. This heuristic attempts to detect square icons with no existing
padding, which is often how favicons are produced. If any transparent
pixel in any corner is detected, no padding is applied.

A future CL will make the icon selection heuristic consistent between
favicons and manifest icons, which will complete the fix for this issue.

BUG=612028
==========

to

==========
Make favicon and manifest icon processing more consistent for add to homescreen.

Manifest icons are used as-provided for add to homescreen on Android,
while favicons are processed to add rounded corners and padding.
This leads to inconsistent icon sizing when a site uses a manifest to
declare icons versus using <link rel="icon"> or favicons.

This CL is a first step in addressing the inconsistency by ensuring both
favicons and manifest icons are processed identically for add to
homescreen. The corner rounding is removed completely, while the
padding process is changed to only be applied on icons which have
nontransparent (alpha != 0) pixels in all four of their corners from either
source. This heuristic attempts to detect square icons with no existing
padding, which is often how favicons are produced. If any transparent
pixel in any corner is detected, no padding is applied.

A future CL will make the icon selection heuristic consistent between
favicons and manifest icons, which will complete the fix for this issue.

BUG=612028

Committed: https://crrev.com/96548fc8973a2e1fa7616d2de7fca20cbe5c98b6
Cr-Commit-Position: refs/heads/master@{#411494}
==========

[commit-bot: I haz the power, 2016-08-12 00:55:23]

Patchset 5 (id:??) landed as
https://crrev.com/96548fc8973a2e1fa7616d2de7fca20cbe5c98b6
Cr-Commit-Position: refs/heads/master@{#411494}