Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

Issue 1997313002: Make favicon and manifest icon processing more consistent for add to homescreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better variable naming Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
index a4e33e8dca4bf94910030cce320e232c68928647..47e8d06c82e4e1ee0faf467a6f38319a623ebb04 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
@@ -94,18 +94,20 @@ class AddToHomescreenDataFetcher
void OnFaviconFetched(
const favicon_base::FaviconRawBitmapResult& bitmap_result);
- // Creates the launcher icon from the given bitmap and page URL. The page URL
- // is used to generate an icon if there is no bitmap in |bitmap_result| or the
+ // Creates the launcher icon from the given bitmap. shortcut_info_.url is
+ // used to generate an icon if there is no bitmap in |bitmap_result| or the
// bitmap is not large enough.
- void CreateLauncherIconInBackground(
- const GURL& page_url,
+ void CreateLauncherIconFromFaviconInBackground(
const favicon_base::FaviconRawBitmapResult& bitmap_result);
// Called when InstallableManager finishes looking for a manifest and icon.
void OnDidPerformInstallableCheck(const InstallableData& data);
+ // Creates the launcher icon from the given |icon|.
+ void CreateLauncherIconInBackground(const SkBitmap& raw__icon);
+
// Notifies the observer that the shortcut data is all available.
- void NotifyObserver(const GURL& icon_url, const SkBitmap& icon);
+ void NotifyObserver(const SkBitmap& icon);
Observer* weak_observer_;

Powered by Google App Engine
This is Rietveld 408576698