Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1997293002: Introduce SourceLocation to be used for console messages. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce SourceLocation to be used for console messages. SourceLocation is meant to be used instead of ScriptCallStack and beyond, representing a location which triggered something (e.g. a console message). BUG=613882 Committed: https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594 Cr-Commit-Position: refs/heads/master@{#395539}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : compile, tests #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -47 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/postMessage/target-origin-expected.txt View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/bindings/core/v8/SourceLocation.h View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp View 1 2 3 1 chunk +87 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/v8.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 9 chunks +10 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.h View 1 2 3 4 6 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp View 1 2 3 4 5 chunks +21 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997293002/40001
4 years, 7 months ago (2016-05-23 05:21:23 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/70231) chromeos_daisy_chromium_compile_only_ng on ...
4 years, 7 months ago (2016-05-23 05:33:54 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997293002/60001
4 years, 7 months ago (2016-05-23 20:54:50 UTC) #7
dgozman
Take a look please.
4 years, 7 months ago (2016-05-23 21:00:54 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/188327)
4 years, 7 months ago (2016-05-23 21:03:14 UTC) #11
pfeldman
lgtm
4 years, 7 months ago (2016-05-23 22:45:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997293002/60001
4 years, 7 months ago (2016-05-23 23:15:11 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/188469)
4 years, 7 months ago (2016-05-23 23:23:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997293002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997293002/80001
4 years, 7 months ago (2016-05-24 00:03:03 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/226789)
4 years, 7 months ago (2016-05-24 05:13:03 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997293002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997293002/80001
4 years, 7 months ago (2016-05-24 05:36:12 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-24 07:08:00 UTC) #25
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 07:10:00 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/db28b907dc3c6a7b615ac85fc3bb71cd33554594
Cr-Commit-Position: refs/heads/master@{#395539}

Powered by Google App Engine
This is Rietveld 408576698