Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: third_party/WebKit/Source/core/inspector/ConsoleMessage.h

Issue 1997293002: Introduce SourceLocation to be used for console messages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ConsoleMessage.h
diff --git a/third_party/WebKit/Source/core/inspector/ConsoleMessage.h b/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
index 6cde6200dd10876c67c68e150a851270eca7f9c3..a9ebe78c8760e441995d0721df537a48f2d3120b 100644
--- a/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
+++ b/third_party/WebKit/Source/core/inspector/ConsoleMessage.h
@@ -5,7 +5,6 @@
#ifndef ConsoleMessage_h
#define ConsoleMessage_h
-#include "bindings/core/v8/ScriptCallStack.h"
#include "bindings/core/v8/ScriptState.h"
#include "core/CoreExport.h"
#include "platform/heap/Handle.h"
@@ -19,7 +18,10 @@
namespace blink {
class ScriptArguments;
+class ScriptCallStack;
class ScriptState;
+class SourceLocation;
+class V8StackTrace;
class CORE_EXPORT ConsoleMessage final: public GarbageCollectedFinalized<ConsoleMessage> {
public:
@@ -41,6 +43,9 @@ public:
// This method captures callstack.
static ConsoleMessage* createForConsoleAPI(MessageLevel, MessageType, const String& message, ScriptArguments*);
+ static ConsoleMessage* create(MessageSource, MessageLevel, const String& message, PassOwnPtr<SourceLocation>);
+ static ConsoleMessage* create(MessageSource, MessageLevel, const String& message, const String& url, unsigned lineNumber, unsigned columnNumber, PassOwnPtr<V8StackTrace>, int scriptId, ScriptArguments*);
+
~ConsoleMessage();
MessageType type() const;
@@ -48,7 +53,7 @@ public:
const String& url() const;
unsigned lineNumber() const;
unsigned columnNumber() const;
- PassRefPtr<ScriptCallStack> callStack() const;
+ V8StackTrace* stackTrace() const;
ScriptArguments* scriptArguments() const;
unsigned long requestIdentifier() const;
double timestamp() const;
@@ -66,7 +71,7 @@ public:
DECLARE_TRACE();
private:
- ConsoleMessage(MessageSource, MessageLevel, const String& message, const String& url, unsigned lineNumber, unsigned columnNumber, PassRefPtr<ScriptCallStack>, int scriptId, ScriptArguments*);
+ ConsoleMessage(MessageSource, MessageLevel, const String& message, const String& url, unsigned lineNumber, unsigned columnNumber, PassOwnPtr<V8StackTrace>, int scriptId, ScriptArguments*);
MessageSource m_source;
MessageLevel m_level;
@@ -76,7 +81,7 @@ private:
String m_url;
unsigned m_lineNumber;
unsigned m_columnNumber;
- RefPtr<ScriptCallStack> m_callStack;
+ OwnPtr<V8StackTrace> m_stackTrace;
Member<ScriptArguments> m_scriptArguments;
unsigned long m_requestIdentifier;
double m_timestamp;
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp ('k') | third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698