Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1997183002: Cache PrefixElement(s) in LibraryElementImpl. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cache PrefixElement(s) in LibraryElementImpl. This makes DDC compilation about 5% faster. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/593daf05bd0858ef8823e65cad29af200daa88a7

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 3 chunks +15 lines, -7 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 7 months ago (2016-05-21 02:29:10 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/1997183002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/1997183002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode4166 pkg/analyzer/lib/src/dart/element/element.dart:4166: this._imports = imports; We should flush _prefixes here.
4 years, 7 months ago (2016-05-21 15:22:05 UTC) #2
scheglov
https://codereview.chromium.org/1997183002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/1997183002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode4166 pkg/analyzer/lib/src/dart/element/element.dart:4166: this._imports = imports; On 2016/05/21 15:22:05, Brian Wilkerson wrote: ...
4 years, 7 months ago (2016-05-22 01:53:38 UTC) #3
scheglov
4 years, 7 months ago (2016-05-22 01:53:55 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
593daf05bd0858ef8823e65cad29af200daa88a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698