Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: pkg/analyzer/lib/src/dart/element/element.dart

Issue 1997183002: Cache PrefixElement(s) in LibraryElementImpl. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index 721918f655b3c41c20556433c6c7fbce2d5c2916..2a47fda0350bcd44a61f0190d82b9907ddbe38ba 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -3750,7 +3750,7 @@ class ImportElementImpl extends UriReferencedElementImpl
PrefixElement get prefix {
if (_unlinkedImport != null) {
- if (_unlinkedImport.prefixReference != 0) {
+ if (_unlinkedImport.prefixReference != 0 && _prefix == null) {
LibraryElementImpl library = enclosingElement as LibraryElementImpl;
_prefix = new PrefixElementImpl.forSerialized(_unlinkedImport, library);
}
@@ -3976,6 +3976,11 @@ class LibraryElementImpl extends ElementImpl implements LibraryElement {
Namespace _publicNamespace;
/**
+ * The cached list of prefixes.
+ */
+ List<PrefixElement> _prefixes;
+
+ /**
* Initialize a newly created library element in the given [context] to have
* the given [name] and [offset].
*/
@@ -4331,14 +4336,17 @@ class LibraryElementImpl extends ElementImpl implements LibraryElement {
@override
List<PrefixElement> get prefixes {
- HashSet<PrefixElement> prefixes = new HashSet<PrefixElement>();
- for (ImportElement element in _imports) {
- PrefixElement prefix = element.prefix;
- if (prefix != null) {
- prefixes.add(prefix);
+ if (_prefixes == null) {
+ HashSet<PrefixElement> prefixes = new HashSet<PrefixElement>();
+ for (ImportElement element in _imports) {
+ PrefixElement prefix = element.prefix;
+ if (prefix != null) {
+ prefixes.add(prefix);
+ }
}
+ _prefixes = prefixes.toList();
}
- return new List.from(prefixes);
+ return _prefixes;
}
@override
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698