Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: dbus/bus.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Addressed feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dbus/bus.cc
diff --git a/dbus/bus.cc b/dbus/bus.cc
index 1827928b9e04308473269d024b56f7db12d30ffa..19a6ba6a7333de5164728f0de83789d4e300767e 100644
--- a/dbus/bus.cc
+++ b/dbus/bus.cc
@@ -83,13 +83,13 @@ class Watch : public base::MessagePumpLibevent::Watcher {
private:
// Implement MessagePumpLibevent::Watcher.
- void OnFileCanReadWithoutBlocking(int file_descriptor) override {
+ void OnFileCanReadWithoutBlocking(int /*file_descriptor*/) override {
const bool success = dbus_watch_handle(raw_watch_, DBUS_WATCH_READABLE);
CHECK(success) << "Unable to allocate memory";
}
// Implement MessagePumpLibevent::Watcher.
- void OnFileCanWriteWithoutBlocking(int file_descriptor) override {
+ void OnFileCanWriteWithoutBlocking(int /*file_descriptor*/) override {
const bool success = dbus_watch_handle(raw_watch_, DBUS_WATCH_WRITABLE);
CHECK(success) << "Unable to allocate memory";
}
@@ -1095,7 +1095,7 @@ void Bus::OnToggleTimeout(DBusTimeout* raw_timeout) {
}
void Bus::OnDispatchStatusChanged(DBusConnection* connection,
- DBusDispatchStatus status) {
+ DBusDispatchStatus /*status*/) {
DCHECK_EQ(connection, connection_);
AssertOnDBusThread();
@@ -1191,10 +1191,9 @@ void Bus::OnDispatchStatusChangedThunk(DBusConnection* connection,
}
// static
-DBusHandlerResult Bus::OnConnectionDisconnectedFilter(
- DBusConnection* connection,
- DBusMessage* message,
- void* data) {
+DBusHandlerResult Bus::OnConnectionDisconnectedFilter(DBusConnection*,
+ DBusMessage* message,
+ void* /*data*/) {
if (dbus_message_is_signal(message,
DBUS_INTERFACE_LOCAL,
kDisconnectedSignal)) {
@@ -1206,7 +1205,7 @@ DBusHandlerResult Bus::OnConnectionDisconnectedFilter(
// static
DBusHandlerResult Bus::OnServiceOwnerChangedFilter(
- DBusConnection* connection,
+ DBusConnection* /*connection*/,
DBusMessage* message,
void* data) {
if (dbus_message_is_signal(message,

Powered by Google App Engine
This is Rietveld 408576698