components/timers/alarm_timer_chromeos.cc - Issue 1997153002: libchrome: Several upstreamable fixes from libchrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/timers/alarm_timer_chromeos.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Addressed feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/timers/alarm_timer_chromeos.cc

diff --git a/components/timers/alarm_timer_chromeos.cc b/components/timers/alarm_timer_chromeos.cc

index ecf0bd2a2b84bef8d907785845b3b77e6b0a8696..e965f5f8df6c893707922decd095348e87e9f97e 100644

--- a/components/timers/alarm_timer_chromeos.cc

+++ b/components/timers/alarm_timer_chromeos.cc

@@ -253,7 +253,7 @@ void AlarmTimer::Delegate::OnFileCanReadWithoutBlocking(int fd) {

}

-void AlarmTimer::Delegate::OnFileCanWriteWithoutBlocking(int fd) {

+void AlarmTimer::Delegate::OnFileCanWriteWithoutBlocking(int /*fd*/) {

NOTREACHED();

}

« base/metrics/histogram.cc ('K') | « base/values.cc ('k') | dbus/bus.cc » ('j') | no next file with comments »