Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3318)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/debug/alias.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Also fix unit tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/command_line.cc ('K') | « base/command_line.cc ('k') | base/debug/stack_trace_posix.cc » ('j') | base/debug/stack_trace_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/alias.cc
diff --git a/base/debug/alias.cc b/base/debug/alias.cc
index 6b0caaa6d1819657da85341426cd73b19e81df62..6de39d069b53e49074aa5b0f6293b58b45566914 100644
--- a/base/debug/alias.cc
+++ b/base/debug/alias.cc
@@ -12,8 +12,7 @@ namespace debug {
#pragma optimize("", off)
#endif
-void Alias(const void* var) {
-}
+void Alias(const void* /* var */) {}
danakj 2016/05/23 02:59:54 just remove the name, its not saying anything as |
Luis Héctor Chávez 2016/05/24 15:27:52 Done.
#if defined(COMPILER_MSVC)
#pragma optimize("", on)
« base/command_line.cc ('K') | « base/command_line.cc ('k') | base/debug/stack_trace_posix.cc » ('j') | base/debug/stack_trace_posix.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698