base/debug/alias.cc - Issue 1997153002: libchrome: Several upstreamable fixes from libchrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/debug/alias.cc

Issue 1997153002: libchrome: Several upstreamable fixes from libchrome Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Also fix unit tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/debug/alias.h"	5 #include "base/debug/alias.h"

6 #include "build/build_config.h"	6 #include "build/build_config.h"

7	7

8 namespace base {	8 namespace base {

9 namespace debug {	9 namespace debug {

10	10

11 #if defined(COMPILER_MSVC)	11 #if defined(COMPILER_MSVC)

12 #pragma optimize("", off)	12 #pragma optimize("", off)

13 #endif	13 #endif

14	14

15 void Alias(const void* var) {	15 void Alias(const void* /* var */) {}
	danakj 2016/05/23 02:59:54 just remove the name, its not saying anything as \| just remove the name, its not saying anything as \|var\| Luis Héctor Chávez 2016/05/24 15:27:52 Done. Show quoted text On 2016/05/23 02:59:54, danakj wrote: > just remove the name, its not saying anything as \|var\| Done.
16 }

17	16

18 #if defined(COMPILER_MSVC)	17 #if defined(COMPILER_MSVC)

19 #pragma optimize("", on)	18 #pragma optimize("", on)

20 #endif	19 #endif

21	20

22 } // namespace debug	21 } // namespace debug

23 } // namespace base	22 } // namespace base

OLD	NEW