Issue 1997015: Adding Icedtea/OpenJDK to test image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1997015: Adding Icedtea/OpenJDK to test image. (Closed)

Created:
10 years, 7 months ago by Zhenyao Mo

Modified:
9 years, 7 months ago

Reviewers:
sosa, piman

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, rtc, awong, adlr, Chris Masone

Base URL:
ssh://git@chromiumos-git/chromiumos-overlay.git

Visibility:
Public.

Description

Adding Icedtea/OpenJDK to test image.

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chromeos-base/chromeos-test/chromeos-test-0.1.0.ebuild	View		1 chunk	+1 line, -0 lines	1 comment	Download
	M	dev-java/icedtea/icedtea-6.1.7.1.ebuild	View		2 chunks	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years, 7 months ago (2010-05-11 03:32:42 UTC) #2

cpl nits, lgtm otherwise

http://codereview.chromium.org/1997015/diff/1/2
File chromeos-base/chromeos-test/chromeos-test-0.1.0.ebuild (right):

http://codereview.chromium.org/1997015/diff/1/2#newcode45
chromeos-base/chromeos-test/chromeos-test-0.1.0.ebuild:45: dev-java/icedtea
Alphabetical order

http://codereview.chromium.org/1997015/diff/1/3
File dev-java/icedtea/icedtea-6.1.7.1.ebuild (right):

http://codereview.chromium.org/1997015/diff/1/3#newcode100
dev-java/icedtea/icedtea-6.1.7.1.ebuild:100: # build ChromeOS test image.
Chromium OS*

Expand Messages | Collapse Messages