Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1996983003: [ARM64] Make BufferDisassembler print the instruction encoding (Closed)

Created:
4 years, 7 months ago by Pierre Langlois
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM64] Make BufferDisassembler print the instruction encoding This patch changes the disassembly output for ARM64 when tracing compiled code. We used to omit printing the encoding as opposed to what ARM and X64 do. The new turbolizer tool assumes the encoding is printed and gets confused otherwise. This could have been fixed in the tool instead but making disassembly output consistent across architecture seems like a better solution. BUG= Committed: https://crrev.com/438629ba496e4bc6cd6c45529a73064479eb79ca Cr-Commit-Position: refs/heads/master@{#36426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/arm64/disasm-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Pierre Langlois
4 years, 7 months ago (2016-05-20 17:44:37 UTC) #3
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-21 08:53:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996983003/1
4 years, 7 months ago (2016-05-21 12:14:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-21 12:44:57 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 12:46:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/438629ba496e4bc6cd6c45529a73064479eb79ca
Cr-Commit-Position: refs/heads/master@{#36426}

Powered by Google App Engine
This is Rietveld 408576698