src/arm64/disasm-arm64.cc - Issue 1996983003: [ARM64] Make BufferDisassembler print the instruction encoding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/disasm-arm64.cc

Issue 1996983003: [ARM64] Make BufferDisassembler print the instruction encoding (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/disasm-arm64.cc

diff --git a/src/arm64/disasm-arm64.cc b/src/arm64/disasm-arm64.cc

index 2727081ced36fe0442af4541ef88d183d4d70711..2d201eddaca6c6d48f92b2aa3506b33e9e3732f0 100644

--- a/src/arm64/disasm-arm64.cc

+++ b/src/arm64/disasm-arm64.cc

@@ -1802,7 +1802,8 @@ class BufferDisassembler : public v8::internal::DisassemblingDecoder {

~BufferDisassembler() { }

virtual void ProcessOutput(v8::internal::Instruction* instr) {

- v8::internal::SNPrintF(out_buffer_, "%s", GetOutput());

+ v8::internal::SNPrintF(out_buffer_, "%08" PRIx32 " %s",

+ instr->InstructionBits(), GetOutput());

}

private:

« no previous file with comments | « no previous file | no next file » | no next file with comments »