Issue 199693002: Uptake codereview.chromium.org/196343011

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199693002: Uptake codereview.chromium.org/196343011 (Closed)

Created:
6 years, 9 months ago by inferno

Modified:
6 years, 9 months ago

Reviewers:
haraken, Nate Chapin

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1750/

Visibility:
Public.

More Reviews

Description

Uptake codereview.chromium.org/196343011 R=haraken@chromium.org TBR=haraken@chromium.org, japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169177

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/bindings/scripts/code_generator_v8.pm	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/bindings/tests/results/V8TestObject.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

inferno

6 years, 9 months ago (2014-03-13 23:44:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r169177 (presubmit successful).

Expand Messages | Collapse Messages